WARN improve some warnings introduced in PDEP4 (#50529)

MarcoGorelli · web-flow · commit 179dc14af16c · 2023-01-03T10:50:02.000-08:00
improve warnings

Co-authored-by: MarcoGorelli &lt;&gt;
diff --git a/pandas/_libs/tslibs/parsing.pyx b/pandas/_libs/tslibs/parsing.pyx
@@ -1005,7 +1005,8 @@ cdef void _maybe_warn_about_dayfirst(format: str, bint dayfirst):
             )
         if (day_index < month_index) and not dayfirst:
             warnings.warn(
-                f"Parsing dates in {format} format when dayfirst=False was specified. "
+                f"Parsing dates in {format} format when dayfirst=False (the default) "
+                "was specified. "
                 "Pass `dayfirst=True` or specify a format to silence this warning.",
                 UserWarning,
                 stacklevel=find_stack_level(),
diff --git a/pandas/core/tools/datetimes.py b/pandas/core/tools/datetimes.py
@@ -139,7 +139,7 @@ def _guess_datetime_format_for_array(arr, dayfirst: bool | None = False) -> str
                 return guessed_format
             warnings.warn(
                 "Could not infer format, so each element will be parsed "
-                "individually by `dateutil`. To ensure parsing is "
+                "individually, falling back to `dateutil`. To ensure parsing is "
                 "consistent and as-expected, please specify a format.",
                 UserWarning,
                 stacklevel=find_stack_level(),
diff --git a/pandas/tests/io/parser/test_parse_dates.py b/pandas/tests/io/parser/test_parse_dates.py
@@ -2052,7 +2052,7 @@ def test_parse_dot_separated_dates(all_parsers):
             name="a",
         )
         warn = UserWarning
-    msg = "when dayfirst=False was specified"
+    msg = r"when dayfirst=False \(the default\) was specified"
     result = parser.read_csv_check_warnings(
         warn, msg, StringIO(data), parse_dates=True, index_col=0
     )
diff --git a/pandas/tests/tslibs/test_parsing.py b/pandas/tests/tslibs/test_parsing.py
@@ -262,7 +262,8 @@ def test_guess_datetime_format_wrong_type_inputs(invalid_type_dt):
 def test_guess_datetime_format_no_padding(string, fmt, dayfirst, warning):
     # see gh-11142
     msg = (
-        f"Parsing dates in {fmt} format when dayfirst=False was specified. "
+        rf"Parsing dates in {fmt} format when dayfirst=False \(the default\) "
+        "was specified. "
         "Pass `dayfirst=True` or specify a format to silence this warning."
     )
     with tm.assert_produces_warning(warning, match=msg):

Original file line number	Diff line number	Diff line change
`@@ -2052,7 +2052,7 @@ def test_parse_dot_separated_dates(all_parsers):`
`2052`	`2052`	`name="a",`
`2053`	`2053`	`)`
`2054`	`2054`	`warn = UserWarning`
`2055`		`- msg = "when dayfirst=False was specified"`
	`2055`	`+ msg = r"when dayfirst=False \(the default\) was specified"`
`2056`	`2056`	`result = parser.read_csv_check_warnings(`
`2057`	`2057`	`warn, msg, StringIO(data), parse_dates=True, index_col=0`
`2058`	`2058`	`)`