Add Connection Created/Destroyed slots to NodeDataModel #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
AppVeyor is failing. Qt 5.7 no longer exists in appveyor, and it looks like it would be a good idea to specify a build worker image. |
Quincunx271
commented
May 18, 2018
src/FlowScene.cpp
Outdated
| connect(this, &FlowScene::connectionCreated, this, [this](Connection const& c) { setupConnectionSignals(c); }); | ||
|
|
||
| connect(this, &FlowScene::connectionCreated, this, [this](Connection const& c) { sendConnectionCreatedToNodes(c); }); | ||
| connect(this, &FlowScene::connectionDeleted, this, [this](Connection const& c) { sendConnectionDeletedToNodes(c); }); |
Contributor
Author
There was a problem hiding this comment.
Using a lambda instead of
connect(this, &FlowScene::connectionDeleted, this, &FlowScene::sendConnectionDeletedToNodes);The latter works just fine, except the minimal version of Qt we support is 5.2, and there's a bug where it rejects this code (it has a failing static-assertion which is a false positive). If we were willing to up the minimal version of Qt (idk what version it'd be though), this can be simplified
paceholder
pushed a commit
that referenced
this pull request
Feb 10, 2019
paceholder
added a commit
that referenced
this pull request
Feb 10, 2019
Owner
|
Cleaned-up, rebased, squashed and merged as #211 |
Daguerreo
pushed a commit
to Daguerreo/NodeEditor
that referenced
this pull request
Aug 13, 2020
Daguerreo
pushed a commit
to Daguerreo/NodeEditor
that referenced
this pull request
Aug 13, 2020
Daguerreo
pushed a commit
to Daguerreo/NodeEditor
that referenced
this pull request
Aug 13, 2020
paceholder#211) Add signal for embedded widget size changes (paceholder#187) Fix paceholder paceholder#198 Avoid connecting nodes causing a loop Refactoring. Removed an odd "using". Fixed build errors: https://ci.appveyor.com/project/paceholder/nodeeditor/builds/22024775/job/eihd7371k7eo3pn6 Added the example of dynamic node change. Added the signals when ports are added or removed. Fix out of range exception when loading dynamic port nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #174
This adds the following virtual functions to
NodeDataModel:inputConnectionCreated(Connection const&)inputConnectionDeleted(Connection const&)outputConnectionCreated(Connection const&)outputConnectionDeleted(Connection const&)It might be more consistent to just have
connectionCreated(PortType, Connection const&), instead ofinputConnectionCreatedandoutputConnectionCreated, but I believe having them as separate functions is the better approach