Merged
Conversation
This removes the info icon on images that links to the online info page for the image file.
Owner
|
Can we have a test? Otherwise, LGTM. |
Contributor
Author
|
Should have thought of that, I'll add one for |
This adds a test for the `remove_fileinfo` function, and also changes the test input file to include the modifications made by lxml during serialization (e.g. removing the slash in empty tags).
This splits out removal of unused external links into a separate function and adds a test. This also adds adjustment of the favicon path to the rearranged archive structure which was missing before.
Contributor
Author
|
I split out removal of unused external links and added tests for both that and |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two small issues: