Add DrawingRenderContext - #2168
Open
IngeborgAtRS wants to merge 1 commit into
Open
Conversation
* Add a new rendering context for WPF that renders the graph to a DrawingGroup instead of creating WPF elements. This improves performance slightly but most importantly, it avoids the nasty behavior of creating new children to the Canvas during the Render phase. When there are a lot of curves this can cause the WPF Measure/Arrange/Render cycle to break and fail to redraw the curves. * Create a base class WpfRenderContext that holds functionality shared between the different rendering modes. PlotView.RenderContext now returns this type instead of CanvasRenderContext. * Tooltips now work in the PlotView if you use the DrawingRenderContext. * Create a CanvasPlotView in ExampleBrowser.WPF that * Replace Assert.Is* with Assert.That(..., Is.*) in all tests to get rid of legacy NUnit calls * Fix one of the Issues examples that fails unexpectedly if the current culture does not use dot at decimal separator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1794.
Checklist
Changes proposed in this pull request:
Add a new rendering context for WPF that renders the graph to a DrawingGroup instead of creating WPF elements. This improves performance slightly but most importantly, it avoids the nasty behavior of creating new children to the Canvas during the Render phase. When there are a lot of curves this can cause the WPF Measure/Arrange/Render cycle to break and fail to redraw the curves.
Create a base class WpfRenderContext that holds functionality shared between the different rendering modes. PlotView.RenderContext now returns this type instead of CanvasRenderContext.
Tooltips now work in the PlotView if you use the DrawingRenderContext.
Create a CanvasPlotView in ExampleBrowser.WPF that
Replace Assert.Is* with Assert.That(..., Is.*) in all tests to get rid of legacy NUnit calls
Fix one of the Issues examples that fails unexpectedly if the current culture does not use dot at decimal separator.
@oxyplot/admins