Skip to content

Make consistent BaseValue and BaseLine across BarSeries, LinearBarSeries, and HistogramSeries#2001

Merged
Jonarw merged 2 commits intooxyplot:developfrom
VisualMelon:barlog
Jul 11, 2023
Merged

Make consistent BaseValue and BaseLine across BarSeries, LinearBarSeries, and HistogramSeries#2001
Jonarw merged 2 commits intooxyplot:developfrom
VisualMelon:barlog

Conversation

@VisualMelon
Copy link
Contributor

Having merged #1942 (from which all of this work is derived), this makes the BaseValue and BaseLine consistent across all the 'bar-type' series, and exposes the ActualBaseLine as a { public get; protected set; } property.

Checklist

  • I have included examples or tests
  • I have updated the change log
  • I am listed in the CONTRIBUTORS file
  • I have cleaned up the commit history (use rebase and squash)

Changes

  • All 3 series have consistent support for negative values, determined by a BaseValue that defaults to zero.
  • Fixes issues with rendering against log axes by explicit detection and use of YAxis.ClipMinimum to clamp to end of plot
  • All 3 series have consistent support for a BaseLine which is included in the Y-axis: important for log-axes which extend to infinity that they have a sensisble 'reference' baseline. When NaN, actual value is derived for log-axes by dividing the smallest value by 10 (to give some padding to log plots: better ideas welcome (e.g. depend on range of values and base of axis?): computed values is exposed as ActualBaseLine

@oxyplot/admins

IRenderContext rc,
BarItem item,
double baseValue,
double BaseValue,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The capital 'B' is probably an accident?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, and rebased on develop

@Jonarw Jonarw merged commit 952d5c3 into oxyplot:develop Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants