Skip to content

Make HistogramExamples deterministic#1584

Merged
Jonarw merged 1 commit intooxyplot:developfrom
VisualMelon:DeterministicHistogramExamples
May 31, 2020
Merged

Make HistogramExamples deterministic#1584
Jonarw merged 1 commit intooxyplot:developfrom
VisualMelon:DeterministicHistogramExamples

Conversation

@VisualMelon
Copy link
Contributor

Stops the normal-distribution histogram example from crashing.

Checklist

  • I have included examples or tests
  • I have updated the change log
  • I am listed in the CONTRIBUTORS file
  • I have cleaned up the commit history (use rebase and squash)

Changes proposed in this pull request:

  • Make the examples deterministic (fixed seed)
  • Don't give zero values to Math.Log (this is probably what caused the failure)
  • Actually use some of the parameters in the sampling methods (no behavioural change)

@oxyplot/admins

@Jonarw Jonarw merged commit 5b1ab6c into oxyplot:develop May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants