table plugin: Convert all values to strings#36
Merged
theopolis merged 1 commit intoosquery:masterfrom May 29, 2017
theopolis:int-to-str
Merged
table plugin: Convert all values to strings#36theopolis merged 1 commit intoosquery:masterfrom theopolis:int-to-str
theopolis merged 1 commit intoosquery:masterfrom
theopolis:int-to-str
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
TablePluginswe need to send all data to Thrift as strings. We allow tables to useINTEGERtypes with SQL, but need to make a fast-pass at converting values which are not string to string-types.Fixes #28.