Simplify hashMultiFromFile function
#7995
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamer-dead
commented
Apr 18, 2023
| } else if (encoding_ == HASH_ENCODING_TYPE_BASE64) { | ||
| std::stringstream digest; | ||
| for (size_t i = 0; i < length_; i++) { | ||
| digest << hash[i]; |
There was a problem hiding this comment.
As it seems, operator<< should append unsigned char to the stream as a char. So the whole iteration can be simplified with just a copy.
The copy itself can be avoided, but this will require a few casts that look bad.
Looks like I missed a test for this case, will add.
There was a problem hiding this comment.
I've checked new tests with HASH_ENCODING_TYPE_BASE64 with and wthout this particular change and don't see any difference in results.
mike-myers-tob
changed the title
hashMultiFromFile function
mike-myers-tob
added
refactor
|
Looks okay to me, any of the more c folks want to weigh in? (@alessandrogario @Smjert @marcosd4h ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main intent of this PR is to simplify
hashMultiFromFilea little bit:shared_ptrcompletely, because there are no clients that can share the pointer, all usage is localised inhashMultiFromFilefunction.std::movecalls to help the compiler better understand what is going on.To achieve that I have to add new move-ctor for the Hash class. Hope that this is not forbidden.
In other way, this behaviour can be done with
std::unique_ptr<Hash>.PTAL.