Skip to content

Commit b773c72

Browse files
docs: improving documentation
1 parent 7858a5b commit b773c72

2 files changed

Lines changed: 14 additions & 7 deletions

File tree

CONTRIBUTING.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,11 @@ Before submiting a Pull Request, please:
5555

5656
## <a name="cru"></a> Coding rules
5757

58-
This project uses the Airbnb coding style with little exceptions. Details:
58+
This project uses the [Airbnb coding style](https://github.com/airbnb/javascript) with little
59+
exceptions. The project tslint.json file extends tslint-config-airbnb. Check if you have the tslint
60+
extension in your editor.
61+
62+
Details:
5963
- All code **must be tested** by one or more specs.
6064
- The code must also be documented following the [jsdoc guidelines](http://usejsdoc.org/).
6165
- Wrap all code at 100 characters.
@@ -64,7 +68,7 @@ This project uses the Airbnb coding style with little exceptions. Details:
6468

6569
This project follows the [Angular commit message guidelines](https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit).
6670

67-
From the angular js:
71+
From the Angular documentation:
6872

6973
### Commit message format
7074

README.md

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ This library contains common validators that may be used in Orchejs projects. It
1010

1111
This project is divided in two kinds of validators: Global and Local. The first one comprises common validators, which means, anything that are not from a specific country or region. Examples of global validators are email, not null and length checkers. Local validators are anything that belongs to a specific country like zip code, documents as ID cards and so on.
1212

13-
The idea here is to make a public repository that may grow with the community contribution. So if you need a validator that does not exists here, please open a PR and help us to improve it. For contributions, please check the [contributions]() topic.
13+
The idea here is to make a public repository that may grow with the community contribution. So if you need a validator that does not exists here, please open a PR and help us to improve it. For contributions, please check the [contributions](#con) topic.
1414

1515
-------
1616
## Topics
@@ -22,7 +22,7 @@ The idea here is to make a public repository that may grow with the community co
2222
- [Contributing](#con)
2323
- [License](#lic)
2424

25-
## <a name="#huo"></a> How to use it in Orchejs
25+
## <a name="huo"></a> How to use it in Orchejs
2626

2727
### How to install?
2828

@@ -302,7 +302,7 @@ specific country validation, please take a look at [Implementing new Validators]
302302

303303
## <a name="inv"></a> Implementing new Validators
304304

305-
To implement a new validator to use in your project, you should implement the Validator interface.
305+
To create a new validator to your project, you should implement the Validator interface.
306306

307307
All validation rules must be inside of the validate method. For example:
308308

@@ -339,11 +339,14 @@ const validatorError: ValidatorError = {
339339
resolve(validatorError);
340340
```
341341

342-
**Important**: Avoid to use external libraries, except those that are pretty generic like lodash or momentjs. The reason is to avoid excessive dependencies to the project, which may result in more bugs.
342+
**Important**: Avoid to use external libraries, except those that are pretty generic like lodash or
343+
momentjs. This is for keeping away from excessive dependencies as it could result in bugs.
343344

344345
### Share to the community
345346

346-
If you think that your validator can be used by others, please consider sharing to the communit. The first thing is to open an [issue](https://github.com/orchejs/validators/issues/new) and after being accepted, submit your Pull Request.
347+
If you think that your validator can be used by others, please consider sharing to the communit.
348+
The first thing is to open an [issue](https://github.com/orchejs/validators/issues/new) and after
349+
being accepted, submit your Pull Request.
347350

348351
Don't forget to take a look at the [contribution guidelines](#con).
349352

0 commit comments

Comments
 (0)