Skip to content

User-defined exceptions as ProgrammingError #360

Open

Description

@rafaelreuber

What kind of database errors are ProgrammingError? If you raise a user-defined exception through the procedure raise_application_error, the cx_Oracle raising an DatabaseError.

I think is more clear use ProgrammingError for user-defined exceptions instead of DatabaseError.

with connection.cursor() as cursor:
    try:
        cursor.execute("begin raise_application_error(-20000, 'Sometime strange thins just happens'); end;")
    except cx_Oracle.ProgrammingError as e:
        print("Yes, you are busines validation error")
    except cx_Oracle.DatabaseError as e:
        print("Hey i'm not a business validation")

Python Version: 3.7.4
cx_Oracle Version: 7.2.2
oracleinstantclient Version: 12.2
Oracle server Version : 11g XE
SO: Fedora 30

Activity

  1. changed the title [-]Application error are not instance of ProgrammingError[/-] [+]User-defined exceptions as ProgrammingError[/+] on Sep 19, 2019
  2. alexolirib commented on Sep 20, 2019

    @alexolirib

    +1

  3. anthony-tuininga commented on Sep 24, 2019

    @anthony-tuininga
    Member

    ProgrammingError is only raised for errors like "positional and named binds cannot be intermixed". Almost all Oracle errors are raised as DatabaseError. There are some that are raised as IntegrityError and OperationalError. You can take a look at the source for the function cxoError_raiseFromInfo() for the details.

    As for whether ORA-20000 should be defined as a ProgrammingError instead of DatabaseError, that's a matter for debate! I'm sure others might disagree with your evaluation and I'm not sure I'm convinced either. I'll ask @cjbj to give his opinion as well.

  4. rafaelreuber commented on Sep 24, 2019

    @rafaelreuber
    Author

    Another option would be to define a new exception named ApplicationError do deal with user-defined errors.

  5. cjbj commented on Sep 24, 2019

    @cjbj

    I don't think ProgrammingError makes sense for application runtime errors. ApplicationError might be nice, but is the backward compatibility break worth it?

  6. rafaelreuber commented on Sep 26, 2019

    @rafaelreuber
    Author

    If ApplicationError is subclass of DatabaseError, this will not break the backward compatibility.

  7. anthony-tuininga commented on Feb 10, 2020

    @anthony-tuininga
    Member

    True enough. If @cjbj has no objections I'll add it to cx_Oracle 8. It will cover the error numbers from -20000 to -20999.

  8. ancc commented on May 17, 2022

    @ancc

    8.3 doesn't have ApplicationError. Plan is valid to add it?

  9. cjbj commented on May 17, 2022

    @cjbj

    I don't see it in the next major version, so we'll have to revisit when we get a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions