fix: Changed getFeatureVariableJson to getFeatureVariableJSON#516
Merged
mikeproeng37 merged 2 commits intomasterfrom Jul 6, 2020
Merged
fix: Changed getFeatureVariableJson to getFeatureVariableJSON#516mikeproeng37 merged 2 commits intomasterfrom
mikeproeng37 merged 2 commits intomasterfrom
Conversation
mikeproeng37
approved these changes
Jul 1, 2020
Contributor
mikeproeng37
left a comment
mikeproeng37
left a comment
There was a problem hiding this comment.
This looks fine, you'll also need to fix the js-testapp
mjc1283
approved these changes
Jul 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_getFeatureVariableForTypefunction, Moved invalid instance check and log message to their own functions.Test plan
All unit tests FSC tests should pass