feat: Added React Native Client Engines to be sent in events#435
Merged
feat: Added React Native Client Engines to be sent in events#435
Conversation
mjc1283
approved these changes
Apr 1, 2020
2. Added tests to make sure client engine values always end with -sdk
jasonkarns
added a commit
to github/optimizely-javascript-sdk
that referenced
this pull request
May 4, 2020
* tag 'v4.0.0-alpha.1': chore: Prepare for 4.0.0-alpha.1 release (optimizely#439) feat: Added React Native Client Engines to be sent in events (optimizely#435)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added Two new client engine values to be sent in events.
react-native-js
Client Engine will be set to
react-native-jswhen a react native application will use javascript sdk directlyreact-native
Client Engine will be set to
react-nativewhen a react native application will use react sdkClient Versions
Client versions behave correctly without any change. Current behaviour is.
react-native-jsgoes withclientVersionof javascript SDKreact-nativegoes withclientVersionof react SDK.Test plan
Made appropriate changes to already existing unit tests.