Update k8s dependencies to v0.27.2 and controller-runtime to v0.15.0#114
Conversation
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @tiraboschi. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| err = apiv2.AddToScheme(sch) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| cl = fake.NewClientBuilder().WithScheme(sch).Build() | ||
| cl = fake.NewClientBuilder().WithScheme(sch).WithStatusSubresource(operatorCond).Build() |
There was a problem hiding this comment.
| os.Exit(1) | ||
| } | ||
| if err := c.Watch(&source.Kind{Type: &v1.Pod{}}, pause); err != nil { | ||
| if err := c.Watch(source.Kind(mgr.GetCache(), &v1.Pod{}), pause); err != nil { |
There was a problem hiding this comment.
|
@rashmigottipati FYI |
tiraboschi
force-pushed
the
k8s_v0.27.1
branch
2 times, most recently
from
3a8eb3a to
fe56e57
Compare
|
|
||
| BeforeEach(func() { | ||
| q = controllertest.Queue{Interface: workqueue.New()} | ||
| q = &controllertest.Queue{Interface: workqueue.New()} |
There was a problem hiding this comment.
|
|
||
| BeforeEach(func() { | ||
| q = controllertest.Queue{Interface: workqueue.New()} | ||
| q = &controllertest.Queue{Interface: workqueue.New()} |
There was a problem hiding this comment.
| ) | ||
| BeforeEach(func() { | ||
| q = controllertest.Queue{Interface: workqueue.New()} | ||
| q = &controllertest.Queue{Interface: workqueue.New()} |
There was a problem hiding this comment.
tiraboschi
changed the title
- update k8s dependencies to v0.27.2 - update controller-runtime to v0.15.0 - add context to EventHandler calls, see: kubernetes-sigs/controller-runtime#2139 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi
changed the title
|
/retest |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
There was a problem hiding this comment.
/lgtm
The apidiff tests are failing due to the author adding ccontext.Context parameter to EnqueueRequestForAnnotation and InstrumentedEnqueueRequestForObject handlers to comply with controller-runtime v0.15.0. Wondering if we can override this and force merge this PR.
| github.com/go-logr/logr v1.2.4 | ||
| github.com/onsi/ginkgo/v2 v2.9.5 | ||
| github.com/onsi/gomega v1.27.7 | ||
| github.com/operator-framework/api v0.17.4-0.20230223191600-0131a6301e42 |
There was a problem hiding this comment.
TODO: we would have to bump o-f/api once the k8s bump in it is done.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/override go-apidiff |
|
@varshaprasad96: Overrode contexts on behalf of varshaprasad96: go-apidiff DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
Description of the change:
Update k8s dependencies to v0.27.1 and controller-runtime to v0.15.0
Motivation for the change:
keep the pace with k8s development