Skip to content

Bumping to k8s 1.26 and controller-runtime 0.14.1#111

Merged
openshift-merge-robot merged 1 commit intooperator-framework:mainfrom
tiraboschi:bump_st
Jan 26, 2023
Merged

Bumping to k8s 1.26 and controller-runtime 0.14.1#111
openshift-merge-robot merged 1 commit intooperator-framework:mainfrom
tiraboschi:bump_st

Conversation

@tiraboschi
Copy link
Contributor

@tiraboschi tiraboschi commented Jan 3, 2023

Description of the change:

  • Bumping to k8s v1.26
  • Bumping to controller-runtime v0.14.1
  • Update tests to Ginkgo v2

Motivation for the change:
Consume up-to-date dependencies

Signed-off-by: Simone Tiraboschi stirabos@redhat.com

@tiraboschi
Bumping to k8s 1.26 and controller-runtime 0.14.1
bf9a7e2 
* Bumping to k8s v1.26
* Bumping to controller-runtime v0.14.1
* Update tests to Ginkgo v2

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 3, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 3, 2023

Hi @tiraboschi. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joelanford
Copy link
Member

joelanford commented Jan 3, 2023

Thanks @tiraboschi!

@joelanford
Copy link
Member

joelanford commented Jan 3, 2023

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 3, 2023
@coveralls
Copy link

coveralls commented Jan 3, 2023

Pull Request Test Coverage Report for Build 3831388719

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0%) to 84.767%
Totals Coverage Status
Change from base Build 3099953266: 0.0%
Covered Lines: 601
Relevant Lines: 709
💛 - Coveralls

@joelanford
Copy link
Member

joelanford commented Jan 3, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jan 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2023
@tiraboschi
Copy link
Contributor Author

tiraboschi commented Jan 16, 2023

ping

@tiraboschi
Copy link
Contributor Author

tiraboschi commented Jan 24, 2023

@joelanford ping

@joelanford
Copy link
Member

joelanford commented Jan 26, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2023
@openshift-merge-robot openshift-merge-robot merged commit 7fc7204 into operator-framework:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelanford joelanford joelanford approved these changes

@jmrodri jmrodri Awaiting requested review from jmrodri

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees

@joelanford joelanford

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiraboschi @joelanford @coveralls @openshift-merge-robot