🌱 Consolidate e2e CI jobs#993
Merged
everettraven merged 1 commit intooperator-framework:mainfrom Jul 1, 2024
Merged
Conversation
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
m1kola
commented
Jul 1, 2024
Comment on lines
-25
to
-30
| # By default make stops building on first non-zero exit code which | ||
| # in case of E2E tests will mean that code coverage will only be | ||
| # collected on successful runs. We want to collect coverage even | ||
| # after failing tests. | ||
| # With -k flag make will continue the build, but will return non-zero | ||
| # exit code in case of any errors. |
Member
Author
There was a problem hiding this comment.
This commit is not longer relevant since at some point -k was removed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
=======================================
Coverage 77.19% 77.19%
=======================================
Files 17 17
Lines 1206 1206
=======================================
Hits 931 931
Misses 193 193
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
everettraven
approved these changes
Jul 1, 2024
This was referenced Jul 5, 2024
perdasilva
pushed a commit
to LalatenduMohanty/operator-controller
that referenced
this pull request
Aug 13, 2024
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Consolidates 2 E2E jobs in a single workflow.
We will be adding another E2E (for operator-controller upgrade) and it would be good to have some consistency amongst these jobs (e.g. same triggers, etc).
Reviewer Checklist