Skip to content

🌱 Remove E2E test testing rukpak#946

Merged
tmshort merged 1 commit intooperator-framework:mainfrom
m1kola:remove_e2e_test
Jun 18, 2024
Merged

🌱 Remove E2E test testing rukpak#946
tmshort merged 1 commit intooperator-framework:mainfrom
m1kola:remove_e2e_test

Conversation

@m1kola
Copy link
Member

@m1kola m1kola commented Jun 17, 2024 •
edited
Loading

Description

We use rukpak as a library at the moment and want rukpak to have own tests covering limitations such not allowing to install content with webhooks.

This is a follow up for this discussion: #924 (comment)

Added extra coverage for rukpak: operator-framework/rukpak#922

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2024
@netlify
Copy link

netlify bot commented Jun 17, 2024 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 74297c3
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66705bef231d1100083648ae
😎 Deploy Preview https://deploy-preview-946--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@m1kola m1kola force-pushed the remove_e2e_test branch from e679c88 to cc5efb4 Compare June 17, 2024 08:50
@codecov
Copy link

codecov bot commented Jun 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.96%. Comparing base (b4c928c) to head (74297c3).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #946      +/-   ##
==========================================
- Coverage   80.41%   79.96%   -0.46%     
==========================================
  Files          16       16              
  Lines        1103     1103              
==========================================
- Hits          887      882       -5     
- Misses        150      153       +3     
- Partials       66       68       +2
Flag Coverage Δ
e2e 57.66% <ø> (-1.55%) ⬇️
unit 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola m1kola marked this pull request as ready for review June 17, 2024 12:02
@m1kola m1kola requested a review from a team as a code owner June 17, 2024 12:02
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2024
@m1kola m1kola force-pushed the remove_e2e_test branch from cc5efb4 to 6d4df47 Compare June 17, 2024 12:23
@m1kola
Copy link
Member Author

m1kola commented Jun 17, 2024

Something wrong with code coverage report: it dropped to 0 for e2e tests. Even cmd/manager/main.go doesn't have any coverage which is clearly not the case because we run other E2E tests.

@m1kola m1kola marked this pull request as draft June 17, 2024 14:44
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2024
@m1kola m1kola force-pushed the remove_e2e_test branch 3 times, most recently from 908e105 to 3719edf Compare June 17, 2024 15:38
Remove E2E test testing rukpak
74297c3 
We use rukpak as a library at the moment and want
rukpak to have own tests covering limitations such
not allowing to install content with webhooks.

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola m1kola force-pushed the remove_e2e_test branch from 3719edf to 74297c3 Compare June 17, 2024 15:53
@m1kola
Copy link
Member Author

m1kola commented Jun 17, 2024

Something wrong with code coverage report: it dropped to 0 for e2e tests. Even cmd/manager/main.go doesn't have any coverage which is clearly not the case because we run other E2E tests.

No longer can reproduce after rebased on top of main.

@m1kola m1kola marked this pull request as ready for review June 17, 2024 16:08
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2024
tmshort
tmshort approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2024
@tmshort tmshort added this pull request to the merge queue Jun 18, 2024
Merged via the queue into operator-framework:main with commit bfd4142 Jun 18, 2024
@m1kola m1kola deleted the remove_e2e_test branch June 18, 2024 14:50
@m1kola m1kola mentioned this pull request Jun 18, 2024
Closed
This was referenced Jul 2, 2024
Merged
Closed
Merged
@skattoju skattoju mentioned this pull request Sep 9, 2024
Merged
@skattoju skattoju mentioned this pull request Sep 25, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmshort tmshort tmshort approved these changes

Assignees

@tmshort tmshort

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@m1kola @tmshort