✨ Cleanups after bumping Rukpak#928
Merged
varshaprasad96 merged 1 commit intooperator-framework:mainfrom Jun 13, 2024
Merged
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #928 +/- ##
==========================================
+ Coverage 77.45% 79.15% +1.70%
==========================================
Files 17 15 -2
Lines 1153 1084 -69
==========================================
- Hits 893 858 -35
+ Misses 181 157 -24
+ Partials 79 69 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
varshaprasad96
commented
Jun 12, 2024
joelanford
previously approved these changes
Jun 12, 2024
4 tasks
Member
Author
openshift-merge-robot
added
the
needs-rebase
This PR makes the following changes: 1. Removes the use of a separate handler, given rukpak has now externalized its implementation. 2. Removes the unpacking status, which is no longer required with the use of direct registry client. Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
openshift-merge-robot
removed
the
needs-rebase
bentito
changed the title
bentito
changed the title
bentito
reviewed
Jun 13, 2024
bentito
reviewed
Jun 13, 2024
bentito
reviewed
Jun 13, 2024
bentito
reviewed
Jun 13, 2024
joelanford
approved these changes
Jun 13, 2024
Contributor
|
/lgtm |
everettraven
approved these changes
Jun 13, 2024
Contributor
everettraven
left a comment
everettraven
left a comment
There was a problem hiding this comment.
Changes look good to me and seems reasonable to have #929 as a follow up.
This was referenced Jun 14, 2024
This was referenced Jul 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
Description
Reviewer Checklist