Merged
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
varshaprasad96
force-pushed
the
bump/rukpak
branch
from
0b54b7f to
810fdbc
Compare
dtfranz
reviewed
Jun 3, 2024
dtfranz
reviewed
Jun 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #905 +/- ##
==========================================
+ Coverage 73.54% 77.38% +3.83%
==========================================
Files 18 17 -1
Lines 1221 1163 -58
==========================================
+ Hits 898 900 +2
+ Misses 248 183 -65
- Partials 75 80 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bentito
reviewed
Jun 4, 2024
testdata/bundles/registry-v1/package-with-webhooks.v1.0.0/Dockerfile
Outdated
Show resolved
Hide resolved
bentito
reviewed
Jun 4, 2024
dtfranz
reviewed
Jun 4, 2024
4 tasks
tmshort
reviewed
Jun 5, 2024
openshift-merge-robot
added
the
needs-rebase
varshaprasad96
force-pushed
the
bump/rukpak
branch
from
1f9c68e to
61c33db
Compare
openshift-merge-robot
removed
the
needs-rebase
varshaprasad96
force-pushed
the
bump/rukpak
branch
3 times, most recently
from
32e223d to
9cae5f3
Compare
openshift-merge-robot
added
the
needs-rebase
11 tasks
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
Signed-off-by: Todd Short <tshort@redhat.com>
Signed-off-by: Todd Short <tshort@redhat.com>
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
Make the webhooks package name consistent with oterhs Revert the use of unstructured Signed-off-by: Todd Short <tshort@redhat.com>
Signed-off-by: Todd Short <tshort@redhat.com>
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
varshaprasad96
force-pushed
the
bump/rukpak
branch
from
c817ee3 to
1ed0f20
Compare
4 tasks
m1kola
reviewed
Jun 11, 2024
Member
m1kola
left a comment
m1kola
left a comment
There was a problem hiding this comment.
There are still some comment threads which are open. Apart from that - looks good to me.
Signed-off-by: Todd Short <tshort@redhat.com>
Signed-off-by: Todd Short <tshort@redhat.com>
Contributor
|
Made a couple (small) commits to hopefully address the last of the comments... @m1kola ? |
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
Member
Author
|
@m1kola looks like all the comments have been addressed. Could you please provide a lgtm if all is well. |
everettraven
approved these changes
Jun 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
m1kola
approved these changes
Jun 12, 2024
This was referenced Jul 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reviewer Checklist