🌱 Change global var GetInstalledBundle to interface#899
Merged
bentito merged 1 commit intooperator-framework:mainfrom May 30, 2024
Merged
🌱 Change global var GetInstalledBundle to interface#899bentito merged 1 commit intooperator-framework:mainfrom
bentito merged 1 commit intooperator-framework:mainfrom
Conversation
Signed-off-by: Brett Tofel <btofel@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #899 +/- ##
==========================================
- Coverage 77.21% 76.21% -1.01%
==========================================
Files 17 17
Lines 1176 1177 +1
==========================================
- Hits 908 897 -11
- Misses 189 202 +13
+ Partials 79 78 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
everettraven
approved these changes
May 30, 2024
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow on to the helm-poc changes:
We'd like to not have a global variable for
GetInstalledBundle, but instead an easier to test interface.Reviewer Checklist