Open
Conversation
on first look it seems because of missing relative path Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a snapshot/release build failure by making Maven parent resolution explicit for several modules and updates the observability docs to reflect the namespace tag behavior for events.received.
Changes:
- Add
<relativePath>../pom.xml</relativePath>to the<parent>section of several module POMs. - Update the MicrometerMetricsV2 documentation for
events.receivedtags/description.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test-index-processor/pom.xml | Explicitly sets Maven parent relativePath to root pom. |
| sample-operators/pom.xml | Explicitly sets Maven parent relativePath to root pom. |
| migration/pom.xml | Explicitly sets Maven parent relativePath to root pom. |
| micrometer-support/pom.xml | Explicitly sets Maven parent relativePath to root pom. |
| bootstrapper-maven-plugin/pom.xml | Explicitly sets Maven parent relativePath to root pom. |
| docs/content/en/docs/documentation/observability.md | Documents events.received namespace tag as optional (with withNamespaceAsTag()) and updates description. |
Collaborator
|
Any idea of why that change is needed? |
Collaborator
Author
Not entirely sure why this popped up now, but also it is an issue here: Pls take a look, maybe you will have a better idea. (I did not spend too much time on it to analyizing) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on first look it seems because of missing relative path
Signed-off-by: Attila Mészáros a_meszaros@apple.com