feat: add feature switch to use SSA for managing finalizer#2845
Closed
feat: add feature switch to use SSA for managing finalizer#2845
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
metacosm
approved these changes
Jun 30, 2025
Collaborator
metacosm
left a comment
metacosm
left a comment
There was a problem hiding this comment.
Not a big fan of adding yet another flag to control SSA behavior…
Collaborator
Author
|
yeah me neither TBH, would be better without but, this can be life saving in future. |
Collaborator
Author
|
will work on a reproducer before I merge this |
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
this was added to fabric8 client meanwhile Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
force-pushed
the
finalizer-ssa-toggle
branch
from
1f09a47 to
70e8910
Compare
xstefank
approved these changes
Jul 2, 2025
metacosm
reviewed
Jul 2, 2025
| } | ||
|
|
||
| /** | ||
| * Setting this to {@code true}, controllers will use SSA for adding finalizers. |
Collaborator
There was a problem hiding this comment.
It might help to document why it might be a good idea to set this to false, in particular point to the Kubernetes issue.
Collaborator
Author
|
was thinking more about this, and for now this might be not that good idea, let's discuss it further before doing related changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered a weird bug (will describe more in detail later) when adding finalizer with SSA.
Therefore adding explicit feature switch for finalizer management (SSA / no SSA).
Would like to have a patch release with this, but for next minor release (5.2) would set this flag to
false, so by defaultnot use SSA for finalizer managment.
Signed-off-by: Attila Mészáros a_meszaros@apple.com