Conversation
|
closes #1578 |
| @Override | ||
| public void start() throws OperatorException { | ||
| // on restart new executor service is created and needs to be set here | ||
| executor = ExecutorServiceManager.instance().executorService(); |
There was a problem hiding this comment.
Shouldn't the executor service be shut down then in stop?
There was a problem hiding this comment.
Yes but what I meant is that we're lacking symmetry between start and stop here (i.e. the executor service is stopped at another level). Maybe stop should set executor to null to prevent it from being used before being restarted? I guess this is more a theoretical question than a practical one.
|
Kudos, SonarCloud Quality Gate passed! |
| @Override | ||
| public void start() throws OperatorException { | ||
| // on restart new executor service is created and needs to be set here | ||
| executor = ExecutorServiceManager.instance().executorService(); |
There was a problem hiding this comment.
Yes but what I meant is that we're lacking symmetry between start and stop here (i.e. the executor service is stopped at another level). Maybe stop should set executor to null to prevent it from being used before being restarted? I guess this is more a theoretical question than a practical one.
2 participants
No description provided.