Conversation
csviri
requested changes
Aug 24, 2022
csviri
left a comment
csviri
left a comment
Collaborator
There was a problem hiding this comment.
What is not clear to me in this impl, how it should be used in a real life dependent resource, that should override the match method?
Should we showcase that somehow?
csviri
reviewed
Aug 25, 2022
| ```java | ||
|
|
||
| @ControllerConfiguration( | ||
| labelSelector = SELECTOR, |
Collaborator
There was a problem hiding this comment.
I don't get this, we are both using the same formatter from maven, how was this not formatted? It should fail also on build if not properly formatted
Collaborator
Author
There was a problem hiding this comment.
I don't know but I've seen weird things going on with format… it doesn't appear as deterministic as it should be (or rather, the determinism is not obvious to me) 😓
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1392