All Resource Event Sources can handle multiple seconday resources for a primary resources#1169
All Resource Event Sources can handle multiple seconday resources for a primary resources#1169
Conversation
csviri
changed the title
|
@metacosm will review some parts little later, and fix javadoc. But conceptually can be reviewed. |
|
|
||
| import java.util.function.Function; | ||
|
|
||
| public interface IDMapper<R> extends Function<R, String> { |
There was a problem hiding this comment.
I'd rather have an explicit interface with an actual method which name we control rather than a Function extension. Easier to extend at a later time and more self-documenting than a random apply method in implementors, imo.
I'm also unsure about the purpose of this, actually. :(
There was a problem hiding this comment.
yep, will make it more explicit, not extending the function. Tried to explain here, why it is needed:
There was a problem hiding this comment.
pushed.
Can try to explain more in depth here in the javadoc why this needed. But basically we need to have the information if it's a new resource is a new version or just the same as an other. With key check if it referring to same object with equals we check if it changed or not.
…java-operator-sdk into all-multi-resource-es
.../io/javaoperatorsdk/operator/processing/event/source/ExternalResourceCachingEventSource.java
Outdated
Show resolved
Hide resolved
…tor/processing/event/source/ExternalResourceCachingEventSource.java Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
metacosm
force-pushed
the
all-multi-resource-es
branch
from
a4054b8 to
8b48c1d
Compare
| public Optional<Schema> fetchResource(MySQLSchema resource) { | ||
| return schemaService.getSchema(resource.getMetadata().getName()); | ||
| public Set<Schema> fetchResources(MySQLSchema primaryResource) { | ||
| return null; |
There was a problem hiding this comment.
Is this normal? If yes, can you add a comment explaining why, please?
There was a problem hiding this comment.
its not used, delete it.
…java-operator-sdk into all-multi-resource-es
|
Kudos, SonarCloud Quality Gate passed! |
2 participants
No description provided.