Skip to content

Add TrailingComment module to checkstyle #7138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
optionsome wants to merge 5 commits into
base: dev-2.x
Choose a base branch
from
Open

Add TrailingComment module to checkstyle #7138

optionsome wants to merge 5 commits into from

Conversation

@optionsome
Copy link
Member

@optionsome optionsome commented Dec 15, 2025

Summary

Adds TrailingComment module to checkstyle and fixes the issues related to it.

Issue

Relates to #7068

Unit tests

No functional changes

Documentation

Not updated

Changelog

Skipped

@optionsome optionsome added this to the 2.9 (next release) milestone Dec 15, 2025
@optionsome optionsome requested a review from a team as a code owner December 15, 2025 22:13
@optionsome optionsome added !Technical Debt Improve code quality, no functional changes. +Skip Changelog This is not a relevant change for a product owner since last release. labels Dec 15, 2025
@optionsome optionsome mentioned this pull request Dec 15, 2025
Open
66 tasks
@codecov
Copy link

codecov bot commented Dec 15, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 68.71166% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.09%. Comparing base (1fc2003) to head (5d36607).

Files with missing lines Patch % Lines
...java/org/opentripplanner/visualizer/ShowGraph.java 0.00% 15 Missing ⚠️
...planner/graph_builder/module/TripPatternNamer.java 0.00% 6 Missing ⚠️
...anner/ext/siri/updater/azure/SiriAzureUpdater.java 0.00% 3 Missing ⚠️
...pplanner/apis/gtfs/datafetchers/QueryTypeImpl.java 0.00% 3 Missing ⚠️
...lanner/graph_builder/module/ned/VerticalDatum.java 0.00% 3 Missing ⚠️
...t/fares/service/gtfs/v1/custom/HSLFareService.java 33.33% 1 Missing and 1 partial ⚠️
.../opentripplanner/street/model/edge/StreetEdge.java 0.00% 0 Missing and 2 partials ⚠️
...rg/opentripplanner/visualizer/GraphVisualizer.java 0.00% 2 Missing ⚠️
...grastertiles/TraversalPermissionsEdgeRenderer.java 0.00% 1 Missing ⚠️
...ripplanner/ext/edgenaming/PortlandCustomNamer.java 0.00% 1 Missing ⚠️
... and 13 more
Additional details and impacted files 
@@              Coverage Diff              @@
##             dev-2.x    #7138      +/-   ##
=============================================
- Coverage      72.09%   72.09%   -0.01%     
+ Complexity     20696    20693       -3     
=============================================
  Files           2244     2244              
  Lines          83899    83900       +1     
  Branches        8347     8347              
=============================================
- Hits           60489    60487       -2     
  Misses         20483    20483              
- Partials        2927     2930       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@optionsome optionsome requested a review from tkalvas December 16, 2025 09:55
@optionsome optionsome removed the request for review from tkalvas December 17, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leonardehrenfried leonardehrenfried Awaiting requested review from leonardehrenfried

At least 2 approving reviews are required to merge this pull request.

Assignees

@leonardehrenfried leonardehrenfried

@t2gran t2gran

Labels

+Skip Changelog This is not a relevant change for a product owner since last release. !Technical Debt Improve code quality, no functional changes.

Projects

None yet

Milestone

2.9 (next release)

Development

Successfully merging this pull request may close these issues.

4 participants

@optionsome @leonardehrenfried @tkalvas @t2gran