Support gml:LineString format with list of gml:pos elements #7135
+55
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7135 +/- ##
=============================================
+ Coverage 72.05% 72.09% +0.03%
- Complexity 20679 20695 +16
=============================================
Files 2242 2244 +2
Lines 83801 83913 +112
Branches 8348 8350 +2
=============================================
+ Hits 60385 60495 +110
+ Misses 20488 20487 -1
- Partials 2928 2931 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Related: #5697 You might be able to use the test. |
tkalvas
changed the title
| if (o instanceof DirectPositionType directPosition) { | ||
| var values = directPosition.getValue(); | ||
| if (values == null || values.size() != 2) { | ||
| System.out.println("bad lineString element value " + values); |
Member
There was a problem hiding this comment.
Can you get rid of the System.out.println?
| } | ||
| list.addAll(values); | ||
| } else { | ||
| System.out.println("unhandled lineString element type " + o.getClass().getName()); |
Member
There was a problem hiding this comment.
Can you replace this with slf4j or remove?
Contributor
Author
There was a problem hiding this comment.
It's build-time, so I changed it to issueStore.add instead
leonardehrenfried
approved these changes
Dec 19, 2025
vpaturet
approved these changes
Dec 19, 2025
t2gran
pushed a commit
that referenced
this pull request
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
VR has NeTEx data where a ServiceLink is expressed as
This adds support for it.
GML documentation extract for LineString:
We only supported 2, but this PR adds 1 as well.
Unit tests
Yes.
Documentation
Rationale given in this comment.
Changelog
Yes.
Bumping the serialization version id
No.