Add module tests for updating raptor transit data #7129
Merged
+340
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
added
!Technical Debt
| @Test | ||
| @Disabled | ||
| @Disabled( | ||
| "Can be enabled when https://github.com/opentripplanner/OpenTripPlanner/pull/6280 is merged" |
leonardehrenfried
force-pushed
the
routing-pattern-test
branch
3 times, most recently
from
f2f046c to
d87c22e
Compare
leonardehrenfried
force-pushed
the
routing-pattern-test
branch
from
d87c22e to
77609f2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7129 +/- ##
=============================================
+ Coverage 72.05% 72.09% +0.03%
- Complexity 20679 20692 +13
=============================================
Files 2242 2244 +2
Lines 83801 83899 +98
Branches 8348 8347 -1
=============================================
+ Hits 60385 60486 +101
+ Misses 20488 20483 -5
- Partials 2928 2930 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
habrahamsson-skanetrafiken
requested review from
habrahamsson-skanetrafiken,
t2gran and
vpaturet
and removed request for
t2gran
leonardehrenfried
force-pushed
the
routing-pattern-test
branch
3 times, most recently
from
a3a5341 to
3088b0b
Compare
leonardehrenfried
force-pushed
the
routing-pattern-test
branch
from
3088b0b to
35f611c
Compare
leonardehrenfried
force-pushed
the
routing-pattern-test
branch
from
409d80e to
169f760
Compare
habrahamsson-skanetrafiken
requested changes
Dec 17, 2025
application/src/test/java/org/opentripplanner/transit/model/_data/TransitTestEnvironment.java
Outdated
Show resolved
Hide resolved
leonardehrenfried
force-pushed
the
routing-pattern-test
branch
from
277c99a to
96c0c76
Compare
habrahamsson-skanetrafiken
previously approved these changes
Dec 17, 2025
vpaturet
requested changes
Dec 17, 2025
| "Can be enabled when https://github.com/opentripplanner/OpenTripPlanner/pull/6280 is merged" | ||
| ) | ||
| void addedThenRemoved() { | ||
| assertThat(env.raptorData().summarizePatterns()).containsExactly("F:Pattern1"); |
Contributor
There was a problem hiding this comment.
This will fail since the format is %s[%s]?
Should the expectation be "F:Pattern1[SCHEDULED]" ?
Possibly same issue in AssignedStopIdsTest.reuseRealtimeTripPatterns and AssignedStopIdsTest.reuseRealtimeTripPatternsOnDifferentServiceDates()?
habrahamsson-skanetrafiken
approved these changes
Dec 18, 2025
leonardehrenfried
changed the title
vpaturet
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #6280 @miklcct is adding some code that touches the
TimetableSnapshot. I believe, that given the current constraints, this is acceptable, but we should probably add some tests for the current behaviour of the SIRI updaters beforehand.This PR adds them. It builds on the pattern established by @habrahamsson-skanetrafiken: returning fetchers from the environment which can then be further queried.
Unit tests
This PR is only about unit tests.
Documentation
Javadoc.