Add Route/Trip/TripOnServiceDate replacement to query apis #7126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7126 +/- ##
=============================================
+ Coverage 72.05% 72.11% +0.06%
- Complexity 20699 20865 +166
=============================================
Files 2242 2272 +30
Lines 83853 84506 +653
Branches 8366 8426 +60
=============================================
+ Hits 60418 60943 +525
- Misses 20499 20581 +82
- Partials 2936 2982 +46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tkalvas
added
New GraphQL API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds two-directional replacement relation for TripOnServiceDates, and simpler queries for Routes and Trips to find
if there are replacements. Works for both GTFS and NeTEx sources, which have very different capabilities in this
respect.
Issue
Discussion and plan in #6817
Unit tests
Yes.
Testing revealed that when we create a TripOnServiceDate replacing a Trip on some ServiceDate, we do not currently generate a synthetic TripOnServiceDate from that Trip, that the created TOSD could include it in its replacementFor list. For cancellations we create synthetic TOSDs, should we create them for replacements too?
Documentation
Todo.
Changelog
Yes.
Bumping the serialization version id
No.