Add support for Stop IDs/indexes in RaptorDebug #7113
Merged
+66
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teRequest) The ID lookup is done the RaptorRequestMapper
t2gran
added
!Improvement
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7113 +/- ##
=============================================
+ Coverage 72.06% 72.09% +0.03%
- Complexity 20659 20706 +47
=============================================
Files 2235 2241 +6
Lines 83566 83725 +159
Branches 8344 8355 +11
=============================================
+ Hits 60220 60362 +142
- Misses 20422 20434 +12
- Partials 2924 2929 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
application/src/main/java/org/opentripplanner/routing/api/request/DebugRaptorBuilder.java
Outdated
Show resolved
Hide resolved
...org/opentripplanner/routing/algorithm/raptoradapter/transit/mappers/RaptorRequestMapper.java
Show resolved
Hide resolved
leonardehrenfried
requested changes
Dec 4, 2025
Member
leonardehrenfried
left a comment
leonardehrenfried
left a comment
There was a problem hiding this comment.
I have a few small comments.
leonardehrenfried
previously approved these changes
Dec 4, 2025
jessicaKoehnke
approved these changes
Dec 4, 2025
| public class RaptorRequestMapper<T extends RaptorTripSchedule> { | ||
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(RaptorRequestMapper.class); | ||
| private static final Pattern NUMBER_PATTERN = Pattern.compile("\\d+"); |
t2gran
commented
Dec 8, 2025
...org/opentripplanner/routing/algorithm/raptoradapter/transit/mappers/RaptorRequestMapper.java
Outdated
Show resolved
Hide resolved
t2gran
force-pushed
the
support_stop_ids_raptor_debug
branch
from
357d207 to
d107baa
Compare
jessicaKoehnke
approved these changes
Dec 8, 2025
leonardehrenfried
approved these changes
Dec 8, 2025
t2gran
pushed a commit
that referenced
this pull request
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This add support for IDs, not just raptor stop indexes as the input to OTP when debugging path/stops in Raptor. This is a very small improvement and it only apply to debugging travel searches - it does not have an effect on the search itself. The parameter is no exposed on any API, set from
InteractiveOTPMainandSpeedTest.Issue
🟥 No issue, very small improvement.
Closes #45
Unit tests
✅ Updated
Documentation
✅ JavaDoc updated
Changelog
🟥 Not relevant
Bumping the serialization version id
✅
RouteRequest->DebugRaptoris changed, stops and path fields go frominttoString.