Skip to content

Conversation

@optionsome
Copy link
Member

Summary

Adds support for direct routing when there are only via locations with coordinates specified in the request. If there are any via locations without coordinates (visit via locations with just stopLocations or pass-through via locations), direct routing is not executed.

This is currently based on #7090

Issue

Relates to #4887

Unit tests

TODO

Documentation

Not needed

Changelog

From title

@optionsome optionsome added the !New Feature A functional feature targeting the end user. label Dec 1, 2025
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 46.54088% with 170 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.98%. Comparing base (a3ab67c) to head (9eae02e).
⚠️ Report is 30 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...oradapter/router/street/ViaDirectStreetRouter.java 0.00% 103 Missing ⚠️
...uting/algorithm/mapping/ViaLocationTypeMapper.java 42.30% 14 Missing and 1 partial ⚠️
.../opentripplanner/routing/impl/GraphPathFinder.java 54.54% 8 Missing and 2 partials ⚠️
...r/routing/algorithm/mapping/ItinerariesHelper.java 12.50% 7 Missing ⚠️
...algorithm/mapping/RaptorPathToItineraryMapper.java 57.14% 6 Missing ⚠️
...aptoradapter/router/street/DirectStreetRouter.java 79.31% 3 Missing and 3 partials ⚠️
...src/main/java/org/opentripplanner/astar/AStar.java 0.00% 4 Missing ⚠️
...ntripplanner/apis/gtfs/generated/GraphQLTypes.java 0.00% 3 Missing ⚠️
...rg/opentripplanner/model/plan/leg/StopArrival.java 25.00% 3 Missing ⚠️
...rg/opentripplanner/visualizer/GraphVisualizer.java 0.00% 3 Missing ⚠️
... and 7 more
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #7105      +/-   ##
=============================================
- Coverage      72.05%   71.98%   -0.08%     
- Complexity     20642    20685      +43     
=============================================
  Files           2231     2240       +9     
  Lines          83543    83761     +218     
  Branches        8346     8349       +3     
=============================================
+ Hits           60196    60293      +97     
- Misses         20422    20543     +121     
  Partials        2925     2925              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@optionsome optionsome added this to the 2.9 (next release) milestone Dec 1, 2025
t2gran and others added 17 commits December 8, 2025 13:17
The McStopArrivals is a critical class, building the listeners is just noice and can be done in a mapper and injected.

This also remove StopArrivalParetoSet - witch only existed to take part of the listeners construction.

A tiny business rule is no enforced by the the mapper, not ideal, but overall much better than it was. The mapper is responsible for the order the listeners are added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!New Feature A functional feature targeting the end user.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants