-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Support for direct via routing #7105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
optionsome
wants to merge
19
commits into
opentripplanner:dev-2.x
Choose a base branch
from
HSLdevcom:direct-via-routing
base: dev-2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,747
−712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7105 +/- ##
=============================================
- Coverage 72.05% 71.98% -0.08%
- Complexity 20642 20685 +43
=============================================
Files 2231 2240 +9
Lines 83543 83761 +218
Branches 8346 8349 +3
=============================================
+ Hits 60196 60293 +97
- Misses 20422 20543 +121
Partials 2925 2925 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…tions visited in Raptor
The McStopArrivals is a critical class, building the listeners is just noice and can be done in a mapper and injected. This also remove StopArrivalParetoSet - witch only existed to take part of the listeners construction. A tiny business rule is no enforced by the the mapper, not ideal, but overall much better than it was. The mapper is responsible for the order the listeners are added.
…s from all workers.
9eae02e to
1e0526a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for direct routing when there are only via locations with coordinates specified in the request. If there are any via locations without coordinates (visit via locations with just stopLocations or pass-through via locations), direct routing is not executed.
This is currently based on #7090
Issue
Relates to #4887
Unit tests
TODO
Documentation
Not needed
Changelog
From title