Skip to content

Add information about the use of elevators, escalators, and stairs to queries with steps in the GTFS GraphQL API #6897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
VillePihlava merged 122 commits into from
Dec 19, 2025
Merged

Add information about the use of elevators, escalators, and stairs to queries with steps in the GTFS GraphQL API #6897

VillePihlava merged 122 commits into from
Dec 19, 2025

Conversation

@VillePihlava
Copy link
Contributor

@VillePihlava VillePihlava commented Sep 25, 2025 •
edited
Loading

Summary

This PR adds information about the use of elevators, escalators, and stairs to queries with steps in the GTFS GraphQL API. An important part of this PR is the addition of the StreetDetailsService which is used for storing level and incline information for edges. A build config field is provided to enable/disable storing level and incline info for escalators and stairs. Level info is always stored for elevators.

I also did some refactoring where I felt it was necessary, e.g. in EscalatorProcessor and OsmModule.

Issue

Closes #6829

Unit tests

New tests:

  • EdgeLevelInfoTest.java - a new test class for tests related to storing incline/level information for elevators, escalators, and stairs
  • OsmWayTest.java - small changes to osm way testing
  • StatesToWalkStepsMapperTest.java - test related to escalators/stairs/elevators
  • GraphQLIntegrationTest.java - changing steps test by adding ElevatorUse, EscalatorUse, and StairsUse

Documentation

  • Javadoc
  • Build config field summary

@VillePihlava
Add VerticalTransportationUse information to WalkStep.
a480b5c
@VillePihlava
Add VerticalTransportationUse and related changes to GTFS GraphQL sch…
3ba6570 
…ema.
@VillePihlava
Remove id from VerticalTransportationUse type.
42acfdc
@VillePihlava
Implement datafetcher functions.
ce37d29
@VillePihlava
Remove id from VerticalTransportationUse.
9276250
@VillePihlava
Modify walk step building logic for escalators, elevators, and stairs.
65564e8
@VillePihlava
Add new enum logic.
975503a
@VillePihlava
Small changes.
2d056cc
@VillePihlava
Fix enum value.
f761461
@VillePihlava
Remove fields related to VerticalTransportationUse.
6167768
@VillePihlava
Add initial implementation of OsmStreetDecoratorService and OsmStreet…
19dcc00 
…DecoratorRepository.
@VillePihlava
Add initial version of OsmStreetDecorator dagger logic.
bbaff17
@VillePihlava
Change floorNumber to float in OsmLevel.
8873d2a
@VillePihlava
Add levelRef to OsmLevel.
2f31753
@VillePihlava
Change default to null.
23791ae
@VillePihlava
Add isStairs method to OsmWay.
98b0e3b
@VillePihlava
Change OSM level info processing.
f57232c
@VillePihlava
Add isInclineUp and isInclineDown functions.
9941cc9
@VillePihlava
Change OsmStreetDecorator methods.
c6d710e
@VillePihlava
Fix format.
542e450
@VillePihlava
Refactor OsmStreetDecoratorRepository.
e105eab
@VillePihlava
Add method getEdgeLevelInfo to OsmModule.
e37ff1a
@VillePihlava
Add matchesNodes function.
bab8499
@VillePihlava
Refactor EscalatorProcessor.
5c1bf82
@VillePihlava
Add level info to OsmStreetDecoratorRepository.
faeea2e
@VillePihlava
Change VerticalTransportationUse.
bcb5560
@VillePihlava
Add OsmStreetDecoratorService to StatesToWalkStepsMapper.
11bcc46
@VillePihlava
First version of vertical transportation use walk steps.
1640533
@VillePihlava
Change instanceof checks.
b908252
@VillePihlava
Fix step building logic in StatesToWalkStepsMapper.
2a7312e
@VillePihlava
Copy link
Contributor Author

VillePihlava commented Dec 16, 2025

This is ready for review

@VillePihlava VillePihlava changed the title Add StreetDetailsService for storing level and incline information for edges Add information about the use of elevators, escalators, and stairs to queries with steps in the GTFS GraphQL API Dec 18, 2025
optionsome
optionsome previously approved these changes Dec 19, 2025
View reviewed changes
leonardehrenfried
leonardehrenfried previously approved these changes Dec 19, 2025
View reviewed changes
Copy link
Member

@leonardehrenfried leonardehrenfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊

@VillePihlava
Merge branch 'dev-2.x' of github.com:opentripplanner/OpenTripPlanner …
0fa3ab8 
…into stairs-escalators-elevators-gtfs-graphql
@VillePihlava
Copy link
Contributor Author

VillePihlava commented Dec 19, 2025

:shipit: 🚀

@VillePihlava VillePihlava added this pull request to the merge queue Dec 19, 2025
Merged via the queue into opentripplanner:dev-2.x with commit ee2c10f Dec 19, 2025
16 checks passed
@VillePihlava VillePihlava deleted the stairs-escalators-elevators-gtfs-graphql branch December 19, 2025 11:35
t2gran pushed a commit that referenced this pull request Dec 19, 2025
Add changelog entry for #6897 [ci skip]
a9ec54e
t2gran pushed a commit that referenced this pull request Dec 19, 2025
Bump serialization version id for #6897
a43f224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t2gran t2gran t2gran left review comments

@leonardehrenfried leonardehrenfried leonardehrenfried approved these changes

@optionsome optionsome optionsome approved these changes

Assignees

@leonardehrenfried leonardehrenfried

@optionsome optionsome

Labels

+Bump Serialization Id Add this label if you want the serialization id automatically bumped after merging the PR HSL Helsinki Regional Transport Authority !New Feature A functional feature targeting the end user.

Projects

None yet

Milestone

2.9 (next release)

Development

Successfully merging this pull request may close these issues.

Improved indoor navigation: Lifts, stairs and escalators

4 participants

@VillePihlava @t2gran @leonardehrenfried @optionsome