Restore handling of invalid GTFS shape references #6807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
added
the
!Bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6807 +/- ##
=============================================
- Coverage 71.97% 71.97% -0.01%
+ Complexity 19425 19422 -3
=============================================
Files 2099 2098 -1
Lines 78757 78756 -1
Branches 7970 7970
=============================================
- Hits 56685 56682 -3
Misses 19256 19256
- Partials 2816 2818 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # application/src/test/java/org/opentripplanner/graph_builder/module/geometry/GeometryProcessorTest.java
leonardehrenfried
force-pushed
the
shape-id
branch
from
f215511 to
59db621
Compare
binh-dam-ibigroup
approved these changes
Aug 25, 2025
jessicaKoehnke
approved these changes
Aug 26, 2025
t2gran
pushed a commit
that referenced
this pull request
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #6752 I introduced a bug where an invalid GTFS shape ID was not ignored anymore but caused an NPE.
This PR fixes the bug and restores the previous behaviour. I also renamed an issue so it's a little clearer what the problem is.
Unit tests
Added.
Documentation
Issue description.