Exaggerate safest street routing #6785
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6785 +/- ##
=============================================
- Coverage 72.05% 72.04% -0.01%
- Complexity 20644 20651 +7
=============================================
Files 2231 2232 +1
Lines 83543 83567 +24
Branches 8346 8338 -8
=============================================
+ Hits 60198 60207 +9
- Misses 20420 20434 +14
- Partials 2925 2926 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # application/src/main/java/org/opentripplanner/graph_builder/module/osm/OsmModule.java # application/src/test/java/org/opentripplanner/routing/algorithm/mapping/__snapshots__/ElevationSnapshotTest.snap
# Conflicts: # application/src/main/java/org/opentripplanner/street/search/strategy/EuclideanRemainingWeightHeuristic.java
miklcct
force-pushed
the
safest-street
branch
from
407fd88 to
ac0930b
Compare
# Conflicts: # application/src/main/java/org/opentripplanner/graph_builder/module/osm/SafetyValueNormalizer.java # application/src/test/java/org/opentripplanner/routing/algorithm/mapping/__snapshots__/ElevationSnapshotTest.snap
# Conflicts: # application/src/test/java/org/opentripplanner/routing/algorithm/mapping/__snapshots__/ElevationSnapshotTest.snap
# Conflicts: # application/src/main/java/org/opentripplanner/routing/algorithm/raptoradapter/router/street/DirectStreetRouter.java # application/src/main/java/org/opentripplanner/routing/impl/GraphPathFinder.java # application/src/test/java/org/opentripplanner/astar/AStarTest.java # application/src/test/java/org/opentripplanner/routing/algorithm/mapping/__snapshots__/BikeRentalSnapshotTest.snap # application/src/test/java/org/opentripplanner/routing/algorithm/mapping/__snapshots__/ElevationSnapshotTest.snap # application/src/test/java/org/opentripplanner/street/integration/BikeRentalTest.java
# Conflicts: # application/src/main/java/org/opentripplanner/graph_builder/module/osm/OsmModule.java # application/src/test/java/org/opentripplanner/routing/algorithm/mapping/__snapshots__/BikeRentalSnapshotTest.snap # application/src/test/java/org/opentripplanner/routing/algorithm/mapping/__snapshots__/ElevationSnapshotTest.snap
# Conflicts: # application/src/main/java/org/opentripplanner/graph_builder/module/osm/OsmModule.java # application/src/main/java/org/opentripplanner/routing/algorithm/raptoradapter/router/street/DirectStreetRouter.java # application/src/main/java/org/opentripplanner/routing/impl/GraphPathFinder.java # application/src/main/java/org/opentripplanner/street/model/StreetModelDetails.java # application/src/main/java/org/opentripplanner/street/service/StreetLimitationParametersService.java # application/src/test/java/org/opentripplanner/ConstantsForTests.java
# Conflicts: # application/src/main/java/org/opentripplanner/graph_builder/module/osm/OsmModule.java # application/src/main/java/org/opentripplanner/routing/algorithm/raptoradapter/router/street/DirectStreetRouter.java # application/src/main/java/org/opentripplanner/routing/impl/GraphPathFinder.java # application/src/main/java/org/opentripplanner/street/model/StreetModelDetails.java # application/src/main/java/org/opentripplanner/street/service/StreetLimitationParametersService.java # application/src/test/java/org/opentripplanner/ConstantsForTests.java
# Conflicts: # application/src/main/java/org/opentripplanner/graph_builder/module/osm/SafetyValueNormalizer.java # application/src/test/java/org/opentripplanner/street/model/_data/SimpleConcreteEdge.java
miklcct
force-pushed
the
safest-street
branch
from
daed894 to
3c3cbab
Compare
# Conflicts: # application/src/main/java/org/opentripplanner/street/model/edge/StreetEdge.java
miklcct
force-pushed
the
safest-street
branch
from
3c3cbab to
3274de5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adjusts the safest street routing to exaggerate the use of safest streets.
This is based on #6782 as the correct heuristics depends on if the normalizer is removed.
Issue
None yet.
The problem here is that, in the original code, safest street has a negligible difference to safe street routing, unless elevation is involved. The original exaggeration code to exaggerate safety factor of < 0.1 does not really happen in practice, as most safe streets (greenways) are around 0.3 to 0.6, and it never happens before the normalizer was removed.
Therefore, I am adjusting it so the safety values used for safest street routing is the original safety squared times 2, and extracted to a helper method. The effect is that, neutral streets will be avoided, dangerous streets will be avoided at all costs, slightly safe streets (about 0.7) will appear neutral, and very safe streets will be safe.
Unit tests
Added
Documentation
N/A
Changelog
N/A
Bumping the serialization version id
N/A