Convert remaining GTFS-RT tests to module tests #5916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
added
!Technical Debt
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5916 +/- ##
==========================================
Coverage 69.63% 69.63%
Complexity 17129 17129
==========================================
Files 1937 1937
Lines 73742 73738 -4
Branches 7546 7545 -1
==========================================
- Hits 51351 51349 -2
Misses 19754 19754
+ Partials 2637 2635 -2 ☔ View full report in Codecov by Sentry. |
habrahamsson-skanetrafiken
requested changes
Jun 18, 2024
Contributor
habrahamsson-skanetrafiken
left a comment
habrahamsson-skanetrafiken
left a comment
There was a problem hiding this comment.
Nice work! Just some minor comments
src/test/java/org/opentripplanner/updater/trip/moduletests/rejection/InvalidTripIdTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opentripplanner/updater/trip/moduletests/delay/DelayedTest.java
Show resolved
Hide resolved
src/test/java/org/opentripplanner/updater/trip/moduletests/delay/SkippedTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opentripplanner/updater/trip/moduletests/delay/SkippedTest.java
Outdated
Show resolved
Hide resolved
leonardehrenfried
force-pushed
the
gtfsrt-module-tests
branch
3 times, most recently
from
ccca33b to
d4ff444
Compare
Member
Author
|
@habrahamsson-skanetrafiken I extract a few re-usable methods and made the tests a lot more compact and readable. |
leonardehrenfried
force-pushed
the
gtfsrt-module-tests
branch
from
d4ff444 to
0081a07
Compare
leonardehrenfried
force-pushed
the
gtfsrt-module-tests
branch
from
0081a07 to
02cb8f7
Compare
habrahamsson-skanetrafiken
previously approved these changes
Jun 19, 2024
Contributor
habrahamsson-skanetrafiken
left a comment
habrahamsson-skanetrafiken
left a comment
There was a problem hiding this comment.
Much more readable! Approving with a minor comment that you can fix if you want to.
src/test/java/org/opentripplanner/updater/trip/moduletests/addition/AddedTest.java
Outdated
Show resolved
Hide resolved
habrahamsson-skanetrafiken
previously approved these changes
Jun 20, 2024
t2gran
requested changes
Jun 28, 2024
src/test/java/org/opentripplanner/test/support/UpdateResultAssertions.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opentripplanner/test/support/UpdateResultAssertions.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opentripplanner/updater/trip/RealtimeTestEnvironment.java
Show resolved
Hide resolved
src/test/java/org/opentripplanner/updater/trip/RealtimeTestEnvironment.java
Show resolved
Hide resolved
t2gran
requested changes
Jul 3, 2024
src/test/java/org/opentripplanner/updater/trip/RealtimeTestEnvironment.java
Outdated
Show resolved
Hide resolved
t2gran
previously approved these changes
Jul 5, 2024
vpaturet
approved these changes
Jul 17, 2024
Contributor
|
Since this has already been approved earlier and there were only minor changes since then, I guess you can merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This converts the remaining GTFS-RT realtime tests to module tests.
It also does a tiny bit of refactoring in the update handling code.
Issue
#4002
Unit tests
Yes.