Bridge Dagger and Jersey, inject TransitService #5442
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5442 +/- ##
=============================================
- Coverage 67.50% 66.76% -0.75%
+ Complexity 16285 15446 -839
=============================================
Files 1888 1799 -89
Lines 71547 69795 -1752
Branches 7408 7354 -54
=============================================
- Hits 48301 46600 -1701
+ Misses 20747 20733 -14
+ Partials 2499 2462 -37 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
changed the title
Signed-off-by: Thomas Gran <t2gran@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a POK on how to BRIDGE Dagger and Jersey. The ideal would be to replace Jersey DI with Dagger, but bridging is much simpler. The only code needed to do this is in the
JerseyToDaggerBridge, the rest of the changes is to proof that it works by injecting the TransitService.In the current design the
OtpServerRequestContextis responsible for providing a consistent set of Services for a Request coped Resource. I think we can merge this PR, but before we continue injecting other services directly into Resources we need to make sure we can provide a consistent set of RequestScopedServices.Also, I do NOT want to inject anything else then Services into the Resources, so if resource
AbcResourceis using the e.g. RouterConfig then aAbcResourceServiceclass should be created. Dagger should then wire theAbcResourceServiceand Jersey should injectAbcResourceServiceintoAbcResource.Unit tests
Fixed.
Documentation
TODO: I would like to document the layers and injection strategy:
Changelog
Not relevant
Bumping the serialization version id
No.