Skip to content

POC - Refactor transit model #4718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
t2gran wants to merge 39 commits into
base: dev-2.x
Choose a base branch
from
Draft

POC - Refactor transit model #4718

t2gran wants to merge 39 commits into from

Conversation

@t2gran
Copy link
Member

@t2gran t2gran commented Jan 17, 2023 •
edited
Loading

DO NOT MERGE THIS!

Summary

  • We are playing with a new transit model
  • We want to share this and make it visible so we can get some feedback
  • When we have something we want to use, we will probably pick "piece by piece" from this PR and create new PRs. The plan is NOT to merge this.
  • Comments are welcome, but keep it on a "design level" - we can deal with the details when creating PRs with the "piece by piece"

Issue

This is part of #4002

Documentation

This PR contains design doc - witch is included for discussion. I will no longer update the doc in the issue #4002, but update this PR instead. (The link point to the latest version of the doc.)

@t2gran t2gran added !Improvement A functional improvement or micro feature !New Feature A functional feature targeting the end user. !Documentation Improve documentation targeting users and/or developers. !Optimization The feature is to improve performance. !Technical Debt Improve code quality, no functional changes. +Real-Time The issue/PR is related to RealTime updates +Bump Serialization Id Add this label if you want the serialization id automatically bumped after merging the PR labels Jan 17, 2023
@t2gran t2gran added this to the 2.3 milestone Jan 17, 2023
@t2gran t2gran mentioned this pull request Jan 17, 2023
Open
28 tasks
@t2gran t2gran changed the title Otp2 refactor transit model POC - Refactor transit model Jan 17, 2023
@t2gran t2gran force-pushed the otp2_refactor_transit_model branch from b12e942 to 0ce24ad Compare January 17, 2023 19:38
@t2gran t2gran force-pushed the otp2_refactor_transit_model branch 3 times, most recently from dec3437 to 8b7292b Compare January 18, 2023 10:12
@t2gran t2gran force-pushed the otp2_refactor_transit_model branch from 8b7292b to 6f37022 Compare January 18, 2023 10:21
@codecov
Copy link

codecov bot commented Jan 23, 2023 •
edited
Loading

Codecov Report

Base: 61.49% // Head: 61.72% // Increases project coverage by +0.22% 🎉

Coverage data is based on head (5d0ae94) compared to base (edadd09).
Patch coverage: 41.02% of modified lines in pull request are covered.

❗ Current head 5d0ae94 differs from pull request most recent head b63391f. Consider uploading reports for the commit b63391f to get more accurate results

Additional details and impacted files 
@@              Coverage Diff              @@
##             dev-2.x    #4718      +/-   ##
=============================================
+ Coverage      61.49%   61.72%   +0.22%     
- Complexity     12483    12775     +292     
=============================================
  Files           1597     1633      +36     
  Lines          63876    64963    +1087     
  Branches        6921     7053     +132     
=============================================
+ Hits           39281    40097     +816     
- Misses         22376    22611     +235     
- Partials        2219     2255      +36
Impacted Files Coverage Δ
...entripplanner/raptor/util/paretoset/ParetoSet.java 99.09% <ø> (ø)
...algorithm/raptoradapter/transit/SlackProvider.java 92.85% <0.00%> (-7.15%) ⬇️
...anner/transit/model/api/TransitRoutingRequest.java 0.00% <0.00%> (ø)
...ripplanner/transit/model/basic/LocalizedMoney.java 100.00% <ø> (ø)
...org/opentripplanner/transit/model/basic/Money.java 72.72% <ø> (ø)
...pplanner/transit/model/calendar/PatternForDay.java 0.00% <0.00%> (ø)
...planner/transit/model/calendar/PatternsForDay.java 0.00% <0.00%> (ø)
...lanner/transit/model/calendar/PatternsForDays.java 0.00% <0.00%> (ø)
...lanner/transit/model/calendar/TransitCalendar.java 0.00% <0.00%> (ø)
...ansit/model/calendar/TripScheduleSearchOnDays.java 0.00% <0.00%> (ø)
... and 152 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

t2gran and others added 16 commits February 8, 2023 14:36
@t2gran
refactor: Add toString to Timetable and ForwardSearch
864fdf7
@t2gran
fix: Board first trip if earliest-board-time is before first trip (no…
5aecc8b 
… check on previous day)
@t2gran
fix: Trip index returned from search was wrong
d55cedf
@t2gran
todo: Added tests, witch fails - TODO fix the code and tests
25bc469
@vpaturet
Rename parameter stop to stopIndex
21bae68
@vpaturet
Fixed unit tests
9a52d16
@vpaturet
Fix timetable test data
b234a04
@vpaturet
Fix formatting
552de6c
@vpaturet
Added unit tests on Timetable
e038ca9
@t2gran
refactor: Give TripIndexSearch classes better names
3cc6081
@vpaturet
Added fix for AlightTripIndexSearch and BoardTripIndexSearch
713eef9
@vpaturet
Simplify AlightTripIndexSearch and BoardTripIndexSearch
48e4951
@vpaturet
Return test data in TripOnDay.pattern()
a5b3231
@vpaturet
Rename test stops to match test expectation
871662e
@vpaturet
Fix reverse search
e2cc503
@vpaturet
Fix cost value in unit test
b63391f
@t2gran t2gran modified the milestones: 2.3, 2.4 Apr 24, 2023
@t2gran t2gran modified the milestones: 2.4, 2.5 (next release) Sep 13, 2023
@abyrd abyrd mentioned this pull request Dec 19, 2023
Merged
@t2gran t2gran modified the milestones: 2.5, 2.6 (next release) Mar 13, 2024
@t2gran t2gran modified the milestones: 2.6, 2.7 (next release) Sep 18, 2024
@t2gran t2gran removed the !New Feature A functional feature targeting the end user. label Oct 10, 2024
@t2gran t2gran modified the milestones: 2.7, 2.8 (next release) Mar 12, 2025
@t2gran t2gran modified the milestones: 2.8, 2.9 (next release) Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@t2gran t2gran

@vpaturet vpaturet

Labels

+Bump Serialization Id Add this label if you want the serialization id automatically bumped after merging the PR !Documentation Improve documentation targeting users and/or developers. !Improvement A functional improvement or micro feature !Optimization The feature is to improve performance. +Real-Time The issue/PR is related to RealTime updates !Technical Debt Improve code quality, no functional changes.

Projects

None yet

Milestone

2.9 (next release)

Development

Successfully merging this pull request may close these issues.

2 participants

@t2gran @vpaturet