-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Labels
!BugApply to issues describing a bug and PRs witch fixes it.Apply to issues describing a bug and PRs witch fixes it.!OptimizationThe feature is to improve performance.The feature is to improve performance.!Technical DebtImprove code quality, no functional changes.Improve code quality, no functional changes.
Description
Summary
This commit 26e41f4 changes the result of the speed test for the following 3 cases: 1, 14, 22, 23, 33, and 36 (travelSearch.csv included).
This is might be a bug or fixing a bug, but we should probably investigate to find out. This might related to the increased responstime we saw when the PR #6084 was merged into dev-2.x. However, the tests I have done on my local machine and on the OTP performance-test does not indicate anything for this commit. I have not been able to reproduce the performance issue on my local machine, instead all my tests show the opposite - about 6-8% improved performance for the Raptor after the PR #6084 was merged.
I tested with the latest Norwegian dataset (30. Nov 2025).
Details
Test Cases
testCaseId,description,departure,arrival,window,origin,fromPlace,fromLat,fromLon,destination,toPlace,toLat,toLon,category,modes
1,"Intercity Notodden to Oslo",08:00,12:00,2h,Notodden Skysstasjon,NSR:StopPlace:20762,59.556698,9.25651,Oslo Bussterminal,NSR:StopPlace:6505,59.91177,10.757994,transit,TRANSIT|WALK
2,"Intercity Gol to Oslo",11:00,15:00,1h,Gol,NSR:StopPlace:324,60.69917,8.97123,Billingstad,NSR:StopPlace:577,59.874783,10.483057,transit,TRANSIT|WALK
3,"Oslo local, Slependen to city center",15:00,17:00,1h30m,IKEA Slependen,NSR:StopPlace:4401,59.87577,10.500488,Oslo Bussterminal,NSR:StopPlace:6505,59.91177,10.757994,transit,TRANSIT|WALK
4,"Outskirts Sponvika to Skjærhalden",16:00,20:30,1h,Sponvika,NSR:StopPlace:3009,59.09267,11.229988,Skjærhalden,NSR:StopPlace:1845,59.025497,11.036771,transit,TRANSIT|WALK
5,"Rural Ørje to Skjønhaug, Østold",13:00,14:30,1h10m,Ørje busstorg,NSR:StopPlace:911,59.480717,11.656314,Skjønhaug torv,NSR:StopPlace:1005,59.641224,11.315405,transit,TRANSIT|WALK
7,"Oslo outskirts Prinsdal to Solemskogen",17:00,20:00,2h,Prinsdal,NSR:StopPlace:6740,59.834175,10.807415,Solemskogen,NSR:StopPlace:6626,59.979305,10.817612,transit,TRANSIT|WALK
8,"Rural Drevsjø to Dalsbygda",08:00,16:00,2h,Drevsjø,NSR:StopPlace:8674,61.886,12.030646,Dalsbygda sentrum,NSR:StopPlace:8189,62.527782,11.108747,transit,TRANSIT|WALK
9,"Intercity Gjøvik to Lillehammer",15:00,17:00,1h30m,Steinvegen,NSR:StopPlace:14093,61.13245,10.454416,Holsjordet,NSR:StopPlace:14320,61.099922,10.47955,transit,TRANSIT|WALK
10,"Commuter Hokksund to Fossekallveien, Buskerud",08:00,15:00,5h,Hokksund stasjon,NSR:StopPlace:245,59.767204,9.910567,Fossekallveien,NSR:StopPlace:15726,60.178715,10.257535,transit,TRANSIT|WALK
11,"Commuter Torggata to Høyjord, Vestfold",13:00,16:00,1h,Torggata,NSR:StopPlace:17452,59.417572,10.482581,Høyjord,NSR:StopPlace:18872,59.366146,10.120965,transit,TRANSIT|WALK
12,"Commuter Meieritorvet to Sykehjemet, Telemark",10:00,11:30,1h,Meieritorvet,NSR:StopPlace:20257,59.13879,9.648428,Skien sykehjem,NSR:StopPlace:19979,59.213493,9.596075,transit,TRANSIT|WALK
13,"Rural Hastensund to Kolbjørnsvik, Agder",09:30,11:30,1h,Hastensund,NSR:StopPlace:21979,58.50631,8.922674,Kolbjørnsvik,NSR:StopPlace:24171,58.451637,8.76895,transit,TRANSIT|WALK
14,"Rural Hauge to Heskestad, Rogaland",08:00,15:16,4h,Hauge i Dalane,NSR:StopPlace:26062,58.343338,6.29508,Heskestad,NSR:StopPlace:26370,58.490974,6.361217,transit,TRANSIT|WALK
15,"Bergen local, Melkeplassen to Starefossbakken",16:00,18:00,1h30m,Melkeplassen,NSR:StopPlace:31882,60.376045,5.303988,Starefossbakken,NSR:StopPlace:29147,60.387913,5.35192,transit,TRANSIT|WALK
16,"Rural fjords, Helgheim to Vik",14:00,17:00,2h,Helgheim,NSR:StopPlace:34066,61.231983,7.115655,Vik kommunehus,NSR:StopPlace:37210,61.08844,6.579569,transit,TRANSIT|WALK
17,"Local, Ålesund",08:00,10:00,1h15m,Slinningsodden,NSR:StopPlace:41499,62.461693,6.16515,Kråmyra,NSR:StopPlace:40181,62.47539,6.191737,transit,TRANSIT|WALK
18,"Rural via Trondheim, Meldal-Fillan",07:00,20:00,8h,Meldal sentrum,NSR:StopPlace:42516,63.04669,9.713128,Fillan busstasjon,NSR:StopPlace:43785,63.60113,8.973342,transit,TRANSIT|WALK
19,"Rural Verrabotn to Snåsa, Trøndelag",06:00,18:00,4h,Verrabotn,NSR:StopPlace:45683,63.802647,10.581465,Snåsa,NSR:StopPlace:673,64.245766,12.380184,transit,TRANSIT|WALK
20,"Harstad local",15:00,17:00,1h50m,Harstad kirke,NSR:StopPlace:52154,68.801636,16.534492,Lamoveien,NSR:StopPlace:53953,68.81136,16.507952,transit,TRANSIT|WALK
21,"Rural Billefjord to Karasjok, Finnmark",08:00,18:00,8h,Indre Billefjord,NSR:StopPlace:57518,70.31518,25.046686,Karasjok bussterminal,NSR:StopPlace:56754,69.472664,25.5169,transit,TRANSIT|WALK
22,"Outskirts, Hamar-Oslo",09:00,16:00,3h,Hjellum,NSR:StopPlace:11701,61.768383,9.527959,Lyngveien,NSR:StopPlace:6645,59.897415,10.792623,transit,TRANSIT|WALK
23,"Train, Trondheim-Brønnøysund",04:00,26:00,12h,Trondheim S,NSR:StopPlace:659,63.436462,10.398694,Brønnøysund sentrum,NSR:StopPlace:51790,65.4755,12.211214,transit,TRANSIT|WALK
24,"Fly, Sogndal-Molde",08:00,22:00,4h,Sogndal Lufthamn,NSR:StopPlace:750,61.157547,7.137634,Molde Lufthavn,NSR:StopPlace:735,62.746407,7.260933,transit,TRANSIT|WALK
25,"Express bus, Haugesund-Trysil",00:01,26:00,10h,Haugesund bussterminal,NSR:StopPlace:26084,59.416233,5.27443,Trysil busstasjon,NSR:StopPlace:7310,61.318344,12.260398,transit,TRANSIT|WALK
27,"Express bus, Tromsø-Hammerfest",15:00,26:00,3h,Tromsø Prostneset,NSR:StopPlace:52273,69.647705,18.959843,Hammerfest bussterminal,NSR:StopPlace:56676,70.66445,23.680502,transit,TRANSIT|WALK
28,"Oslo high frequency",16:05,18:05,2h,Marienlyst,,59.932322,10.724663,Kjøbenhavngata,,59.928979,10.769432,transit,TRANSIT|WALK
29,"Too high heuristic cost OTP#3835",19:30,21:00,0h30m,Hauketo stasjon,NSR:StopPlace:6710,59.845947,10.803125,Steinberg stasjon,NSR:StopPlace:58839,59.75957,9.961188,transit,TRANSIT|WALK
30,"Crossing Oslo to Asker",09:00,,2h,Lillestrøm,,59.9559,11.0509,Asker,,59.8367,10.4249,transit,TRANSIT|WALK
31,"Crossing Oslo to Hokksund",09:00,,2h,Lillestrøm,,59.9559,11.0509,Hokksund,,59.7705,9.9088,transit,TRANSIT|WALK
33,"Stavanger to Bergen",09:00,,2h,Stavanger,,58.9698356,5.7278252,Bergen,,60.3920207,5.329484,transit,TRANSIT|WALK
36,"Drammen to Ålesund",10:00,,3h,Drammen,,59.7176376,10.2612305,Ålesund,,62.4869530,6.1303710,transit,TRANSIT|WALK
40,"Carl Berners Plass to Kolbotn - arrive by",,19:00,,Carl Berners Plass,,59.9261, 10.7753,Kolbotn,,59.8112, 10.7986,transit,TRANSIT|WALK
41,"Spikkestad to Gardemoen - arrive by",,17:00,,Spikkestad,NSR:StopPlace:694,59.7453,10.3417,Gardemoen,NSR:StopPlace:269,60.1931,11.0968,transit,RAIL|WALK
SpeedTest config
{
"feedId" : "RB",
"testDate": "2025-12-03",
"graph": "../../otp/norway/graph-otp2-${otp.serialization.version.id}.obj",
"tuningParameters": {
"dynamicSearchWindow": {
"minTransitTimeCoefficient": 0.75,
"minWaitTimeCoefficient": 0.0
},
"stopTransferCost": {
"DISCOURAGED": 86400,
"ALLOWED": 3000,
"RECOMMENDED": 300,
"PREFERRED": 0
}
},
"routingDefaults": {
"streetRoutingTimeout": "5s",
"numItineraries" : 12,
"transferPenalty": 0,
"turnReluctance": 1.0,
"elevatorBoardTime": 90,
"elevatorBoardCost": 90,
"elevatorHopTime" : 20,
"elevatorHopCost": 20,
"bicycle": {
"speed": 5,
"reluctance": 5.0,
"boardCost": 600,
"walk": {
"reluctance": 10.0
},
"parking": {
"cost": 120
}
},
"car" : {
"reluctance": 10,
"decelerationSpeed": 2.9,
"accelerationSpeed": 2.9,
"rental": {
"dropOffTime": "120s"
}
},
"walk": {
"speed": 1.3,
"reluctance": 4.0,
"stairsReluctance": 1.65,
"boardCost": 600
},
"wheelchairAccessibility": {
"trip": {
"onlyConsiderAccessible" : false
},
"stop": {
"onlyConsiderAccessible": false
},
"elevator": {
"onlyConsiderAccessible": false
}
},
"otherThanPreferredRoutesPenalty": 300,
"transferSlack": 120,
"boardSlackForMode" : {
"AIRPLANE": "35m"
},
"alightSlackForMode": {
"AIRPLANE": "15m"
},
"accessEgress": {
"maxDurationForMode": {
"BIKE_RENTAL": "20m",
"SCOOTER_RENTAL": "20m"
}
},
"maxDirectStreetDurationForMode": {
"CAR": "12h"
},
"itineraryFilters": {
"transitGeneralizedCostLimit": {
"costLimitFunction": "900 + 1.5x",
"intervalRelaxFactor": 0.75
},
"bikeRentalDistanceRatio": 0.3
},
"ignoreRealtimeUpdates": false,
"geoidElevation": false,
"maxJourneyDuration" : "36h",
"drivingDirection": "right",
"transferOptimization": {
"optimizeTransferWaitTime": true,
"minSafeWaitTimeFactor": 5.0,
"backTravelWaitTimeFactor": 1.0,
"extraStopBoardAlightCostsFactor": 8.0
},
"relaxTransitGroupPriority": "12m + 1.12x",
"transitGroupPriority": {
"global": [
{
"modes": [
"AIRPLANE"
]
}, {
"subModes": [
"localCarFerry"
]
}, {
"agencies": [
"RB:FLT:Authority:FLT"
]
}, {
"subModes": [
"highSpeedRail",
"regionalRail",
"interregionalRail",
"longDistance",
"international",
"sleeperRailService",
"nightRail",
"replacementRailService",
"crossCountryRail",
"railReplacementBus"
]
}, {
"agencies": [
"RB:ATU:Authority:1",
"RB:BOR:Authority:1",
"RB:BSR:Authority:1",
"RB:BSR:Authority:2",
"RB:TID:Authority:TID",
"RB:UNI:Authority:UNI"
]
}, {
"agencies": [
"RB:VYB:Authority:1",
"RB:VYX:Authority:1"
]
}, {
"agencies": [
"RB:FLI:Authority:FlixMobility"
]
}, {
"agencies": [
"RB:NBU:Authority:002"
]
}, {
"agencies": [
"RB:NWY:Authority:d1ea7af1-3c2a-4825-893f-21408ef08480"
]
}
]
}
}
}Metadata
Metadata
Assignees
Labels
!BugApply to issues describing a bug and PRs witch fixes it.Apply to issues describing a bug and PRs witch fixes it.!OptimizationThe feature is to improve performance.The feature is to improve performance.!Technical DebtImprove code quality, no functional changes.Improve code quality, no functional changes.