Add test for mapper

leonardehrenfried · leonardehrenfried · commit fed34b672377 · 2025-12-16T08:55:30.000+01:00
diff --git a/application/src/ext-test/java/org/opentripplanner/gtfs/mapping/TimeframeMapperTest.java b/application/src/ext-test/java/org/opentripplanner/gtfs/mapping/TimeframeMapperTest.java
@@ -0,0 +1,30 @@
+package org.opentripplanner.gtfs.mapping;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.time.LocalTime;
+import org.junit.jupiter.api.Test;
+import org.onebusaway.gtfs.model.AgencyAndId;
+import org.onebusaway.gtfs.model.Timeframe;
+
+class TimeframeMapperTest {
+
+  private static final IdFactory A = new IdFactory("A");
+  public static final LocalTime START = LocalTime.NOON;
+  public static final LocalTime END = START.plusHours(1);
+
+  @Test
+  void map() {
+    var tf = new Timeframe();
+    tf.setTimeframeGroupId(new AgencyAndId("a", "1"));
+    tf.setId(new AgencyAndId("a", "1"));
+    tf.setStartTime(START);
+    tf.setEndTime(END);
+    tf.setServiceId("s1");
+
+    var mapper = new TimeframeMapper(A);
+    var mapped = mapper.map(tf);
+    assertEquals(START, mapped.startTime());
+    assertEquals(END, mapped.endTime());
+  }
+}
diff --git a/application/src/ext/java/org/opentripplanner/ext/fares/model/Timeframe.java b/application/src/ext/java/org/opentripplanner/ext/fares/model/Timeframe.java
@@ -5,6 +5,7 @@
 import java.io.Serializable;
 import java.time.LocalTime;
 import org.opentripplanner.core.model.id.FeedScopedId;
+import org.opentripplanner.utils.tostring.ValueObjectToStringBuilder;
 
 /**
  * A fare timeframe which can model at what times on which dates a fare rule applies.
@@ -36,4 +37,17 @@ public LocalTime startTime() {
   public LocalTime endTime() {
     return end;
   }
+
+  @Override
+  public String toString() {
+    return ValueObjectToStringBuilder.of()
+      .addText("[")
+      .addObj(start)
+      .addText("-")
+      .addObj(end)
+      .addText(",")
+      .addObj(serviceId)
+      .addText("]")
+      .toString();
+  }
 }
diff --git a/application/src/test/java/org/opentripplanner/gtfs/mapping/FareLegRuleMapperTest.java b/application/src/test/java/org/opentripplanner/gtfs/mapping/FareLegRuleMapperTest.java
@@ -3,6 +3,8 @@
 import static com.google.common.truth.Truth.assertThat;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
+import java.time.LocalTime;
+import java.util.Collection;
 import java.util.List;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
@@ -11,6 +13,7 @@
 import org.onebusaway.gtfs.model.FareLegRule;
 import org.onebusaway.gtfs.model.FareMedium;
 import org.onebusaway.gtfs.model.FareProduct;
+import org.onebusaway.gtfs.model.Timeframe;
 import org.opentripplanner.ext.fares.model.FareDistance;
 import org.opentripplanner.ext.fares.model.FareDistance.LinearDistance;
 import org.opentripplanner.ext.fares.model.FareDistance.Stops;
@@ -157,6 +160,45 @@ void noProductFound() {
     );
   }
 
+  @Test
+  void timeframes() {
+    var timeframeMapper = timeframeMapper();
+    var productMapper = new FareProductMapper(ID_FACTORY);
+    var ruleMapper = new FareLegRuleMapper(
+      ID_FACTORY,
+      productMapper,
+      timeframeMapper,
+      DataImportIssueStore.NOOP
+    );
+
+    var product = cashProduct(null);
+    productMapper.map(product);
+
+    var tfId = new AgencyAndId("1", "tf1");
+    var tf = new Timeframe();
+    tf.setTimeframeGroupId(tfId);
+    tf.setStartTime(LocalTime.NOON);
+    tf.setEndTime(LocalTime.NOON.plusHours(1));
+    tf.setServiceId("s1");
+    timeframeMapper.map(tf);
+
+    var obaRule = new FareLegRule();
+    obaRule.setFareProductId(product.getFareProductId());
+    obaRule.setFromTimeframeGroupId(tfId);
+    obaRule.setToTimeframeGroupId(tfId);
+
+    var mapped = List.copyOf(ruleMapper.map(List.of(obaRule))).getFirst();
+
+    assertEquals("[[12:00-13:00,A:s1]]", toStr(mapped.fromTimeframes()));
+    assertEquals("[[12:00-13:00,A:s1]]", toStr(mapped.toTimeframes()));
+  }
+
+  private static String toStr(
+    Collection<org.opentripplanner.ext.fares.model.Timeframe> timeframes
+  ) {
+    return timeframes.stream().map(t -> t.toString()).toList().toString();
+  }
+
   private static FareProduct cashProduct(FareMedium creditMedium) {
     var productId = new AgencyAndId("1", "1");
     var cashProduct = new FareProduct();
