Merged
Conversation
opentaco
approved these changes
Jun 9, 2023
isabella618033
approved these changes
Jun 9, 2023
| __spec_version__ = 1003 | ||
| __version__ = "1.0.3" | ||
| version_split = __version__.split(".") | ||
| __spec_version__ = (1000 * int(version_split[0])) + (10 * int(version_split[1])) + (1 * int(version_split[2])) |
Collaborator
There was a problem hiding this comment.
would it still work if the sub version is >= 10? xd
eg. 1.0.35 -> 1035
1.3.5 -> 1035
Contributor
Author
There was a problem hiding this comment.
No, so v1.35.0 would work, but not 1.0.35
Contributor
There was a problem hiding this comment.
fair point, but as the authors and maintainers we should hold ourselves responsible for the conventions we keep.
There should be an agreed upon limit to the sub version fields. If we are going to exceed 10 revisions (0-9) we should use different prefactors such as 10,000, 100, 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.