Skip to content

make sure to serve the axon first#127

Merged
p-ferreira merged 8 commits intostagingfrom
hotfix/serve-val-axon
Aug 16, 2023
Merged

make sure to serve the axon first#127
p-ferreira merged 8 commits intostagingfrom
hotfix/serve-val-axon

Conversation

@camfairchild
Copy link
Contributor

This is a hotfix for #120
This change serves the axon to the chain

Copy link
Contributor

@opentaco opentaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A --neuron.axon_off flag would be useful, to make axon serving optional, unless there is a reason the axon is mandatory.

This should probably require a manual update, so that validators can specify their --axon.port --axon.external_port --axon.external_ip settings correctly, given that axon is only now introduced.

@camfairchild
Copy link
Contributor Author

A --neuron.axon_off flag would be useful, to make axon serving optional, unless there is a reason the axon is mandatory.

We made it mandatory because of a DoS attack. If your Validator has no IP served, it is blacklisted in the firewall of most miners

@camfairchild
Copy link
Contributor Author

A --neuron.axon_off flag would be useful, to make axon serving optional, unless there is a reason the axon is mandatory.

This should probably require a manual update, so that validators can specify their --axon.port --axon.external_port --axon.external_ip settings correctly, given that axon is only now introduced.

Added your suggestion in eb39381

Also added a catch around the process to log without crashing if it fails 99f64b8

@camfairchild camfairchild changed the base branch from main to staging August 16, 2023 15:44
@p-ferreira p-ferreira mentioned this pull request Aug 16, 2023
@p-ferreira p-ferreira merged commit 8267b2e into staging Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants