Skip to content

Commit ff91e26

Browse files
committed
Update image cli doc and fix some typos
Change-Id: I0a8d095e51a96804c97612e28fac2d00aa94c638 Closes-Bug: #1711284
1 parent 50099d3 commit ff91e26

File tree

2 files changed

+38
-28
lines changed

2 files changed

+38
-28
lines changed

doc/source/cli/command-objects/image.rst

Lines changed: 37 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ Associate project with image
1616
1717
openstack image add project
1818
[--project-domain <project-domain>]
19-
<image> <project>
19+
<image>
20+
<project>
2021
2122
.. option:: --project-domain <project-domain>
2223

@@ -60,7 +61,8 @@ Create/upload an image
6061
[--public | --private | --community | --shared]
6162
[--property <key=value> [...] ]
6263
[--tag <tag> [...] ]
63-
[--project <project> [--project-domain <project-domain>]]
64+
[--project <project>]
65+
[--project-domain <project-domain>]
6466
<image-name>
6567
6668
.. option:: --id <id>
@@ -153,11 +155,11 @@ Create/upload an image
153155

154156
.. option:: --property <key=value>
155157

156-
Set a property on this image (repeat for multiple values)
158+
Set a property on this image (repeat option to set multiple properties)
157159

158160
.. option:: --tag <tag>
159161

160-
Set a tag on this image (repeat for multiple values)
162+
Set a tag on this image (repeat option to set multiple tags)
161163

162164
.. versionadded:: 2
163165

@@ -205,13 +207,12 @@ List available images
205207
openstack image list
206208
[--public | --private | --shared]
207209
[--property <key=value>]
210+
[--name <name>]
211+
[--status <status>]
208212
[--long]
209213
[--sort <key>[:<direction>]]
210214
[--limit <num-images>]
211215
[--marker <image>]
212-
[--name <name>]
213-
[--status <status>]
214-
215216
216217
.. option:: --public
217218
@@ -231,6 +232,18 @@ List available images
231232
232233
Filter output based on property
233234
235+
.. option:: --name <name>
236+
237+
Filter images based on name
238+
239+
*Image version 2 only.*
240+
241+
.. option:: --status <status>
242+
243+
Filter images based on status
244+
245+
*Image version 2 only*
246+
234247
.. option:: --long
235248
236249
List additional fields in output
@@ -251,15 +264,6 @@ List available images
251264
The last image of the previous page. Display list of images
252265
after marker. Display all images if not specified. (name or ID)
253266
254-
.. option:: --name <name>
255-
256-
Filter images based on name
257-
258-
.. option:: --status <status>
259-
260-
Filter images based on status
261-
262-
263267
*Image version 2 only*
264268
265269
image remove project
@@ -272,7 +276,7 @@ Disassociate project with image
272276
.. program:: image remove project
273277
.. code:: bash
274278
275-
openstack image remove remove
279+
openstack image remove project
276280
[--project-domain <project-domain>]
277281
<image>
278282
<project>
@@ -347,8 +351,9 @@ Set image properties
347351
[--os-distro <os-distro>]
348352
[--os-version <os-version>]
349353
[--ramdisk-id <ramdisk-id>]
350-
[--activate|--deactivate]
351-
[--project <project> [--project-domain <project-domain>]]
354+
[--deactivate | --activate]
355+
[--project <project>]
356+
[--project-domain <project-domain>]
352357
[--accept | --reject | --pending]
353358
<image>
354359
@@ -460,7 +465,7 @@ Set image properties
460465
461466
.. option:: --tag <tag>
462467
463-
Set a tag on this image (repeat for multiple values)
468+
Set a tag on this image (repeat option to set multiple tags)
464469
465470
.. versionadded:: 2
466471
@@ -500,15 +505,15 @@ Set image properties
500505
501506
.. versionadded:: 2
502507
503-
.. option:: --activate
508+
.. option:: --deactivate
504509
505-
Activate the image.
510+
Deactivate the image.
506511
507512
.. versionadded:: 2
508513
509-
.. option:: --deactivate
514+
.. option:: --activate
510515
511-
Deactivate the image.
516+
Activate the image.
512517
513518
.. versionadded:: 2
514519
@@ -568,8 +573,13 @@ Display image details
568573
.. code:: bash
569574
570575
openstack image show
576+
[--human-readable]
571577
<image>
572578
579+
.. option:: --human-readable
580+
581+
Print image size in a human-friendly format.
582+
573583
.. _image_show-image:
574584
.. describe:: <image>
575585
@@ -585,16 +595,16 @@ Unset image tags or properties
585595
.. program:: image unset
586596
.. code:: bash
587597
588-
openstack image set
598+
openstack image unset
589599
[--tag <tag>]
590-
[--property <property>]
600+
[--property <property-key>]
591601
<image>
592602
593603
.. option:: --tag <tag>
594604
595605
Unset a tag on this image (repeat option to unset multiple tags)
596606
597-
.. option:: --property <property>
607+
.. option:: --property <property-key>
598608
599609
Unset a property on this image (repeat option to unset multiple properties)
600610

openstackclient/image/v2/image.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -995,7 +995,7 @@ def get_parser(self, prog_name):
995995
parser.add_argument(
996996
"--property",
997997
dest="properties",
998-
metavar="<property_key>",
998+
metavar="<property-key>",
999999
default=[],
10001000
action='append',
10011001
help=_("Unset a property on this image "

0 commit comments

Comments
 (0)