Skip to content

Commit ff85c62

Browse files
committed
flake8-import-order: Ensure to place project imports last
To ensure project imports are placed after third party import, we need to specify application-import-names. Previously flake8-import-check checked only standard imports or not. Change-Id: Iad7afa456cec7cf5b44955f1ea03c593a4c0e426
1 parent 5cc4d5b commit ff85c62

File tree

5 files changed

+8
-6
lines changed

5 files changed

+8
-6
lines changed

openstackclient/tests/functional/compute/v2/test_keypair.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@
1313
import json
1414
import tempfile
1515

16-
from openstackclient.tests.functional import base
17-
1816
from tempest.lib.common.utils import data_utils
1917
from tempest.lib import exceptions
2018

19+
from openstackclient.tests.functional import base
20+
2121

2222
class KeypairBase(base.TestCase):
2323
"""Methods for functional tests."""

openstackclient/tests/functional/identity/v3/test_service_provider.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,10 @@
1010
# License for the specific language governing permissions and limitations
1111
# under the License.
1212

13-
from openstackclient.tests.functional.identity.v3 import common
1413
from tempest.lib.common.utils import data_utils
1514

15+
from openstackclient.tests.functional.identity.v3 import common
16+
1617

1718
class ServiceProviderTests(common.IdentityTests):
1819
# Introduce functional test cases for command 'Service Provider'

openstackclient/tests/unit/api/test_compute_v2.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@
1313

1414
"""Compute v2 API Library Tests"""
1515

16+
from keystoneclient import session
17+
from osc_lib import exceptions as osc_lib_exceptions
1618
from requests_mock.contrib import fixture
1719

18-
from keystoneclient import session
1920
from openstackclient.api import compute_v2 as compute
2021
from openstackclient.tests.unit import utils
21-
from osc_lib import exceptions as osc_lib_exceptions
2222

2323

2424
FAKE_PROJECT = 'xyzpdq'

openstackclient/tests/unit/network/test_common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
import argparse
1515

1616
import mock
17-
1817
import openstack
18+
1919
from openstackclient.common import exceptions
2020
from openstackclient.network import common
2121
from openstackclient.tests.unit import utils

tox.ini

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,3 +92,4 @@ exclude = .git,.tox,dist,doc,*lib/python*,*egg,build,tools
9292
# Doc: http://flake8.readthedocs.org/en/latest/config.html#default
9393
ignore = __
9494
import-order-style = pep8
95+
application_import_names = openstackclient

0 commit comments

Comments
 (0)