Skip to content

Commit fe8a50b

Browse files
committed
Convert network qos functional tests to JSON
Change-Id: Ie5cde2f927ec6abb6334ea01adfb06749384ed01
1 parent 95e2791 commit fe8a50b

File tree

3 files changed

+193
-233
lines changed

3 files changed

+193
-233
lines changed

openstackclient/tests/functional/network/v2/test_network_qos_policy.py

Lines changed: 33 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -13,75 +13,61 @@
1313
# License for the specific language governing permissions and limitations
1414
# under the License.
1515

16+
import json
1617
import uuid
1718

1819
from openstackclient.tests.functional.network.v2 import common
1920

2021

2122
class NetworkQosPolicyTests(common.NetworkTests):
2223
"""Functional tests for QoS policy"""
23-
HEADERS = ['Name']
24-
FIELDS = ['name']
25-
26-
@classmethod
27-
def setUpClass(cls):
28-
common.NetworkTests.setUpClass()
29-
if cls.haz_network:
30-
cls.NAME = uuid.uuid4().hex
31-
32-
opts = cls.get_opts(cls.FIELDS)
33-
raw_output = cls.openstack(
34-
'network qos policy create ' +
35-
cls.NAME +
36-
opts
37-
)
38-
cls.assertOutput(cls.NAME + "\n", raw_output)
39-
40-
@classmethod
41-
def tearDownClass(cls):
42-
try:
43-
if cls.haz_network:
44-
raw_output = cls.openstack(
45-
'network qos policy delete ' +
46-
cls.NAME
47-
)
48-
cls.assertOutput('', raw_output)
49-
finally:
50-
super(NetworkQosPolicyTests, cls).tearDownClass()
5124

5225
def setUp(self):
5326
super(NetworkQosPolicyTests, self).setUp()
5427
# Nothing in this class works with Nova Network
5528
if not self.haz_network:
5629
self.skipTest("No Network service present")
5730

31+
self.NAME = uuid.uuid4().hex
32+
cmd_output = json.loads(self.openstack(
33+
'network qos policy create -f json ' +
34+
self.NAME
35+
))
36+
self.addCleanup(self.openstack,
37+
'network qos policy delete ' + self.NAME)
38+
self.assertEqual(self.NAME, cmd_output['name'])
39+
40+
def test_qos_rule_create_delete(self):
41+
# This is to check the output of qos policy delete
42+
policy_name = uuid.uuid4().hex
43+
self.openstack('network qos policy create -f json ' + policy_name)
44+
raw_output = self.openstack(
45+
'network qos policy delete ' + policy_name)
46+
self.assertEqual('', raw_output)
47+
5848
def test_qos_policy_list(self):
59-
opts = self.get_opts(self.HEADERS)
60-
raw_output = self.openstack('network qos policy list' + opts)
61-
self.assertIn(self.NAME, raw_output)
49+
cmd_output = json.loads(self.openstack(
50+
'network qos policy list -f json'))
51+
self.assertIn(self.NAME, [p['Name'] for p in cmd_output])
6252

6353
def test_qos_policy_show(self):
64-
opts = self.get_opts(self.FIELDS)
65-
raw_output = self.openstack('network qos policy show ' + self.NAME +
66-
opts)
67-
self.assertEqual(self.NAME + "\n", raw_output)
54+
cmd_output = json.loads(self.openstack(
55+
'network qos policy show -f json ' + self.NAME))
56+
self.assertEqual(self.NAME, cmd_output['name'])
6857

6958
def test_qos_policy_set(self):
7059
self.openstack('network qos policy set --share ' + self.NAME)
71-
opts = self.get_opts(['shared'])
72-
raw_output = self.openstack('network qos policy show ' + self.NAME +
73-
opts)
74-
self.assertEqual("True\n", raw_output)
60+
cmd_output = json.loads(self.openstack(
61+
'network qos policy show -f json ' + self.NAME))
62+
self.assertTrue(cmd_output['shared'])
7563

7664
def test_qos_policy_default(self):
7765
self.openstack('network qos policy set --default ' + self.NAME)
78-
opts = self.get_opts(['is_default'])
79-
raw_output = self.openstack('network qos policy show ' + self.NAME +
80-
opts)
81-
self.assertEqual("True\n", raw_output)
66+
cmd_output = json.loads(self.openstack(
67+
'network qos policy show -f json ' + self.NAME))
68+
self.assertTrue(cmd_output['is_default'])
8269

8370
self.openstack('network qos policy set --no-default ' + self.NAME)
84-
opts = self.get_opts(['is_default'])
85-
raw_output = self.openstack('network qos policy show ' + self.NAME +
86-
opts)
87-
self.assertEqual("False\n", raw_output)
71+
cmd_output = json.loads(self.openstack(
72+
'network qos policy show -f json ' + self.NAME))
73+
self.assertFalse(cmd_output['is_default'])

0 commit comments

Comments
 (0)