Ensure show on absent appcreds raises exception

m-bull · stephenfin · commit 9916aa6bc15a · 2025-10-02T10:53:09.000+01:00
Currently, running ``application credential show`` on a non-existent appcred will exit normally and display a formatted application credential with no data, despite the Keystone API returning a 404. Ensure that querying a non-existent application credential raises an exception message and an exit-code 1 to the user. Closes-Bug: #2126565 Change-Id: I597d2d4064f1020c5ac40862ecc556f3c94b53eb Signed-off-by: Matt Anson <matta@stackhpc.com> (cherry picked from commit fb8cdd4)
diff --git a/openstackclient/identity/v3/application_credential.py b/openstackclient/identity/v3/application_credential.py
@@ -352,7 +352,7 @@ def take_action(self, parsed_args):
         user_id = conn.config.get_auth().get_user_id(conn.identity)
 
         application_credential = identity_client.find_application_credential(
-            user_id, parsed_args.application_credential
+            user_id, parsed_args.application_credential, ignore_missing=False
         )
 
         return _format_application_credential(application_credential)
diff --git a/openstackclient/tests/unit/identity/v3/test_application_credential.py b/openstackclient/tests/unit/identity/v3/test_application_credential.py
@@ -457,7 +457,7 @@ def test_application_credential_show(self):
         columns, data = self.cmd.take_action(parsed_args)
 
         self.identity_sdk_client.find_application_credential.assert_called_with(
-            user_id, self.application_credential.id
+            user_id, self.application_credential.id, ignore_missing=False
         )
 
         self.assertEqual(self.columns, columns)
diff --git a/releasenotes/notes/bug-2126565-a119ac242d9ac795.yaml b/releasenotes/notes/bug-2126565-a119ac242d9ac795.yaml
@@ -0,0 +1,8 @@
+---
+fixes:
+  - |
+    Running ``openstack application credential show`` on
+    a non-existent application credential does not
+    raise an exception.
+
+    [Bug `2126565 <https://bugs.launchpad.net/python-openstackclient/+bug/2126565>`_]

Original file line number	Diff line number	Diff line change
`@@ -352,7 +352,7 @@ def take_action(self, parsed_args):`
`352`	`352`	`user_id = conn.config.get_auth().get_user_id(conn.identity)`
`353`	`353`
`354`	`354`	`application_credential = identity_client.find_application_credential(`
`355`		`- user_id, parsed_args.application_credential`
	`355`	`+ user_id, parsed_args.application_credential, ignore_missing=False`
`356`	`356`	`)`
`357`	`357`
`358`	`358`	`return _format_application_credential(application_credential)`
Original file line number	Diff line number	Diff line change
`@@ -457,7 +457,7 @@ def test_application_credential_show(self):`
`457`	`457`	`columns, data = self.cmd.take_action(parsed_args)`
`458`	`458`
`459`	`459`	`self.identity_sdk_client.find_application_credential.assert_called_with(`
`460`		`- user_id, self.application_credential.id`
	`460`	`+ user_id, self.application_credential.id, ignore_missing=False`
`461`	`461`	`)`
`462`	`462`
`463`	`463`	`self.assertEqual(self.columns, columns)`