Merge "Show final image state after image create"

Zuul · openstack-gerrit · commit 5de803b39f87 · 2025-02-10T11:57:11.000Z
diff --git a/openstackclient/image/v2/image.py b/openstackclient/image/v2/image.py
@@ -576,6 +576,9 @@ def _take_action_image(self, parsed_args):
         if parsed_args.filename:
             fp.close()
 
+        # NOTE(pas-ha): create_image returns the image object as it was created
+        # before the data was uploaded, need a refresh to show the final state
+        image = image_client.get_image(image)
         return _format_image(image)
 
     def _take_action_volume(self, parsed_args):
diff --git a/openstackclient/tests/unit/image/v2/test_image.py b/openstackclient/tests/unit/image/v2/test_image.py
@@ -55,6 +55,7 @@ def setUp(self):
         self.new_image = image_fakes.create_one_image()
         self.image_client.create_image.return_value = self.new_image
         self.image_client.update_image.return_value = self.new_image
+        self.image_client.get_image.return_value = self.new_image
 
         self.project_mock.get.return_value = self.project
 
@@ -89,6 +90,7 @@ def test_image_reserve_no_options(self, raw_input):
             container_format=_image.DEFAULT_CONTAINER_FORMAT,
             disk_format=_image.DEFAULT_DISK_FORMAT,
         )
+        self.image_client.get_image.assert_called_once_with(self.new_image)
 
         self.assertEqual(self.expected_columns, columns)
         self.assertCountEqual(self.expected_data, data)
@@ -146,6 +148,7 @@ def test_image_reserve_options(self, raw_input):
             is_protected=self.new_image.is_protected,
             visibility=self.new_image.visibility,
         )
+        self.image_client.get_image.assert_called_once_with(self.new_image)
 
         self.assertEqual(self.expected_columns, columns)
         self.assertCountEqual(self.expected_data, data)
@@ -243,6 +246,7 @@ def test_image_create_file(self):
             tags=self.new_image.tags,
             filename=imagefile.name,
         )
+        self.image_client.get_image.assert_called_once_with(self.new_image)
 
         self.assertEqual(self.expected_columns, columns)
         self.assertCountEqual(self.expected_data, data)
@@ -275,6 +279,7 @@ def test_image_create__progress_ignore_with_stdin(
             data=fake_stdin,
             validate_checksum=False,
         )
+        self.image_client.get_image.assert_called_once_with(self.new_image)
 
         self.assertEqual(self.expected_columns, columns)
         self.assertCountEqual(self.expected_data, data)
@@ -315,6 +320,7 @@ def test_image_create_import(self, raw_input):
             disk_format=_image.DEFAULT_DISK_FORMAT,
             use_import=True,
         )
+        self.image_client.get_image.assert_called_once_with(self.new_image)
 
     @mock.patch('osc_lib.utils.find_resource')
     @mock.patch('openstackclient.image.v2.image.get_data_from_stdin')
