volume: fix volume service set call

cardoe · cardoe · commit 51ecb5f98486 · 2025-07-16T08:48:45.000-05:00
The command line operation could never work due to the incorrect call of
the openstacksdk API. This is updated to make it work and report errors
back to the user.

Closes-Bug: #2116969
Change-Id: I87cc410853c03b00dd1549d67cb1b9a8145bcfaa
Signed-off-by: Doug Goldstein &lt;cardoe@cardoe.com&gt;
diff --git a/openstackclient/volume/v2/service.py b/openstackclient/volume/v2/service.py
@@ -126,7 +126,7 @@ def take_action(self, parsed_args):
         volume_client = self.app.client_manager.sdk_connection.volume
 
         service = volume_client.find_service(
-            host=parsed_args.host, service=parsed_args.service
+            parsed_args.service, ignore_missing=False, host=parsed_args.host
         )
 
         if parsed_args.enable:
diff --git a/openstackclient/volume/v3/service.py b/openstackclient/volume/v3/service.py
@@ -133,7 +133,7 @@ def take_action(self, parsed_args):
         volume_client = self.app.client_manager.sdk_connection.volume
 
         service = volume_client.find_service(
-            host=parsed_args.host, service=parsed_args.service
+            parsed_args.service, ignore_missing=False, host=parsed_args.host
         )
 
         if parsed_args.enable:
diff --git a/releasenotes/notes/volume-service-set-fix-345a8bc84267f743.yaml b/releasenotes/notes/volume-service-set-fix-345a8bc84267f743.yaml
@@ -0,0 +1,5 @@
+---
+fixes:
+  - |
+    The 'volume service set' command could not work due to a bad API call.
+    [Bug `2116969 <https://bugs.launchpad.net/bugs/2116969>`_]

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ def take_action(self, parsed_args):`
`126`	`126`	`volume_client = self.app.client_manager.sdk_connection.volume`
`127`	`127`
`128`	`128`	`service = volume_client.find_service(`
`129`		`- host=parsed_args.host, service=parsed_args.service`
	`129`	`+ parsed_args.service, ignore_missing=False, host=parsed_args.host`
`130`	`130`	`)`
`131`	`131`
`132`	`132`	`if parsed_args.enable:`
Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ def take_action(self, parsed_args):`
`133`	`133`	`volume_client = self.app.client_manager.sdk_connection.volume`
`134`	`134`
`135`	`135`	`service = volume_client.find_service(`
`136`		`- host=parsed_args.host, service=parsed_args.service`
	`136`	`+ parsed_args.service, ignore_missing=False, host=parsed_args.host`
`137`	`137`	`)`
`138`	`138`
`139`	`139`	`if parsed_args.enable:`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +fixes:
 +  - |
 +    The 'volume service set' command could not work due to a bad API call.
 +    [Bug `2116969 <https://bugs.launchpad.net/bugs/2116969>`_]