Fix credential creation

tipabu · tipabu · commit 1979c20ff0ce · 2025-02-25T10:30:22.000-08:00
openstacksdk's Credential expects user_id and project_id, not user and
project. Previously, we would send payloads like

   {'type': 'ec2', 'blob': '{"access": "s3-user1", "secret": "s3-secret1"}'}

which Keystone would reject with

   'user_id' is a required property

Change-Id: I0544bef7df9247395f0726ea075112d6ac992252
diff --git a/openstackclient/identity/v3/credential.py b/openstackclient/identity/v3/credential.py
@@ -88,10 +88,10 @@ def take_action(self, parsed_args):
         else:
             project = None
         credential = identity_client.create_credential(
-            user=user_id,
+            user_id=user_id,
             type=parsed_args.type,
             blob=parsed_args.data,
-            project=project,
+            project_id=project,
         )
 
         return _format_credential(credential)
diff --git a/openstackclient/tests/unit/identity/v3/test_credential.py b/openstackclient/tests/unit/identity/v3/test_credential.py
@@ -73,10 +73,10 @@ def test_credential_create_no_options(self):
         columns, data = self.cmd.take_action(parsed_args)
 
         kwargs = {
-            'user': self.credential.user_id,
+            'user_id': self.credential.user_id,
             'type': self.credential.type,
             'blob': self.credential.blob,
-            'project': None,
+            'project_id': None,
         }
         self.identity_sdk_client.create_credential.assert_called_once_with(
             **kwargs
@@ -105,10 +105,10 @@ def test_credential_create_with_options(self):
         columns, data = self.cmd.take_action(parsed_args)
 
         kwargs = {
-            'user': self.credential.user_id,
+            'user_id': self.credential.user_id,
             'type': self.credential.type,
             'blob': self.credential.blob,
-            'project': self.credential.project_id,
+            'project_id': self.credential.project_id,
         }
         self.identity_sdk_client.create_credential.assert_called_once_with(
             **kwargs
