Skip to content

Commit 0c2dee5

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "Identity: Deprecate --region None in limits/registered limits"
2 parents e27fd93 + 060d706 commit 0c2dee5

File tree

2 files changed

+33
-0
lines changed

2 files changed

+33
-0
lines changed

openstackclient/identity/v3/limit.py

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,13 @@ def take_action(self, parsed_args):
9090
region = common_utils.get_resource(
9191
identity_client.regions, parsed_args.region
9292
)
93+
else:
94+
self.log.warning(
95+
_(
96+
"Passing 'None' to indicate no region is deprecated. "
97+
"Instead, don't pass --region."
98+
)
99+
)
93100

94101
limit = identity_client.limits.create(
95102
project,
@@ -158,6 +165,14 @@ def take_action(self, parsed_args):
158165
region = common_utils.get_resource(
159166
identity_client.regions, parsed_args.region
160167
)
168+
else:
169+
self.log.warning(
170+
_(
171+
"Passing 'None' to indicate no region is deprecated. "
172+
"Instead, don't pass --region."
173+
)
174+
)
175+
161176
project = None
162177
if parsed_args.project:
163178
project = utils.find_resource(

openstackclient/identity/v3/registered_limit.py

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,13 @@ def take_action(self, parsed_args):
8181
region = common_utils.get_resource(
8282
identity_client.regions, parsed_args.region
8383
)
84+
else:
85+
self.log.warning(
86+
_(
87+
"Passing 'None' to indicate no region is deprecated. "
88+
"Instead, don't pass --region."
89+
)
90+
)
8491

8592
registered_limit = identity_client.registered_limits.create(
8693
service,
@@ -182,6 +189,13 @@ def take_action(self, parsed_args):
182189
region = common_utils.get_resource(
183190
identity_client.regions, parsed_args.region
184191
)
192+
else:
193+
self.log.warning(
194+
_(
195+
"Passing 'None' to indicate no region is deprecated. "
196+
"Instead, don't pass --region."
197+
)
198+
)
185199

186200
registered_limits = identity_client.registered_limits.list(
187201
service=service,
@@ -280,6 +294,10 @@ def take_action(self, parsed_args):
280294
region = common_utils.get_resource(
281295
identity_client.regions, parsed_args.region
282296
)
297+
else:
298+
self.log.warning(
299+
_("Passing 'None' to indicate no region is deprecated.")
300+
)
283301

284302
registered_limit = identity_client.registered_limits.update(
285303
parsed_args.registered_limit_id,

0 commit comments

Comments
 (0)