Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openstack/keystoneauth
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: openstack/keystoneauth
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: stable/2024.2
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 3 files changed
  • 2 contributors

Commits on Sep 6, 2024

  1. Update .gitreview for stable/2024.2 

    Change-Id: I1c01e10e4a898d49d522aacfe4166f1e7da76b7e
    @openstackadmin
    openstackadmin committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    bfbfc18 View commit details
    Browse the repository at this point in the history

  2. Update TOX_CONSTRAINTS_FILE for stable/2024.2 

    Update the URL to the upper-constraints file to point to the redirect
rule on releases.openstack.org so that anyone working on this branch
will switch to the correct upper-constraints list automatically when
the requirements repository branches.

Until the requirements repository has as stable/2024.2 branch, tests will
continue to use the upper-constraints list on master.

Change-Id: I2c17b31bb4e567c36cdf45778f9e500f40ba6088
    @openstackadmin
    openstackadmin committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    08439df View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Pass oidc client id in the body if no client secret provided 

    we already are doing this for OidcDeviceAuthorization, so
let's do it in general.

Currently keystoneauth is broken for some providers after
I2392ef51302804c0c66c0fb52227db5f35bca3fd

OpenID Connect spec lists that client auth should be passed either
in the header as HTTP basic auth, or in the request body
https://openid.net/specs/openid-connect-core-1_0.html#ClientAuthentication

With this patch it should work for all variations in providers
I've witnessed personally, including the "onelogin" mentioned in
I2392ef51302804c0c66c0fb52227db5f35bca3fd.

Change-Id: I70fcf7f1eeeeebc621bfd52787bb8d8adb322e67
Closes-Bug: #2078437
(cherry picked from commit 796c999)
    @pshchelo @d34dh0r53
    pshchelo authored and d34dh0r53 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    a6cf0cf View commit details
    Browse the repository at this point in the history
Loading