feat: Enable Content Security Policy (CSP) - #4502
Open
jekkos wants to merge 2 commits into
Open
Conversation
- Enable $CSPEnabled = true in app/Config/App.php - CSP directives already configured in ContentSecurityPolicy.php - Includes support for CSP 3 keywords and directives Closes #4488
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe application configuration now enables Content Security Policy by default by setting ChangesContent Security Policy default
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
|
Enabling CSP currently breaks a lot. This PR needs to mitigate those. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$CSPEnabled = trueinapp/Config/App.phpapp/Config/ContentSecurityPolicy.phpCSP Configuration
The existing ContentSecurityPolicy.php includes:
defaultSrcwith self and www.google.comscriptSrcwith self, unsafe-inline, unsafe-eval, and Google domainsstyleSrcwith self, unsafe-inline, and nonce supportimageSrcwith self, data:, blob:connectSrcwith self and nominatim.openstreetmap.orgfontSrcwith Google Fonts domainsNotes
unsafe-inlinein scriptSrc allows existing inline scripts to work during transitionRelated
Closes #4488
Summary by CodeRabbit